Twitch tab reload, scripts are loaded only on specific sites, extension button only visible on saltybet #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 24, 2015 17:12
Related to #55? Sometimes when the twitch-tab is created, the twitch_content.js script does not load. A reload should probably fix this. Additionally, I've split the scripts and matches into the 2 pages so unnecessary scripts are not loaded anymore on both sites.
Changing it to page_action and adding the lines to the background-script disables the button for all sites but saltybet.com.
This reverts commit d6f2518.
synkarius
added a commit
that referenced
this pull request
Jul 25, 2015
Twitch tab reload, scripts are loaded only on specific sites, extension button only visible on saltybet
|
I tested this with Chrome and Canary. I'm unable to see the SaltBot icon anywhere now, even on www.saltybet.com. I haven't pushed it to the Chrome Store yet. |
Closed
|
Sorry for that, I thought hostEquals would function without www as I've seen 'example.com' used. hostSuffix only compares everything after the www, so I've changed that. |
|
After disabling uBlock and Ghostery it works perfectly without reloading, so I'm removing the reload again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.