Restarting DBus before install certmonger

[arxcruz]

If DBus is updated before run this module and the machine not get
restarted, the certmonger fails (among other services that relies
on dbus service).

[JAORMX]

@locknut @earsdown could you take a look?

[locknut]

Not sure if managing the dbus service is within the scope of this module. Even if we do this, I think we should have a $manage_dbus_service parameter at a minimum?

[locknut]

Also, if this problem appears only when upgrading from dbus 7.4 to 7.5, then is it really necessary for this module to handle that specific condition?

[arxcruz]

Added manage_dbus_service option

[JAORMX]

This looks good to me, and it's reasonably turned off by default. Which we can enable for such cases as that update.

[cjeanner]

might be good to properly define the dbus service - for example, there's this module available on the puppet forge, and the service definition:
https://github.com/bodgit/puppet-dbus/blob/master/manifests/service.pp

[cjeanner]

Not really usefuly to set this, according to the doc: "Specify a restart command manually. If left unspecified, the service will be stopped and then started"

[JAORMX]

What options to we have for this?

[cjeanner]

well, you can actually define the proper restart command if you want. But such a service, there's no use doing so I guess.

[JAORMX]

I think the commit is ready, @locknut what do you think?

[JAORMX]

@locknut @earsdown could you take a look at this if you have some time?

[locknut]

Sorry it's taken a few days to get to this. Had a look. Don't think this PR can be accepted (yet?) for a number of reasons, and maybe we've misunderstood, so help us understand if we've got this wrong.

1. The issue only presents itself during the process of upgrading from dbus 7.4 to 7.5? Or does this issue occur when trying to install certmonger on a system running dbus >=7.5? Does it occur at runtime (e.g. during system boot)? Can someone link me to the actual bug?
2. Will this commit actually result in a restart of the dbus service after installing certmonger? Shouldn't the dbus service subscribe to the certmonger package? Or should the dbus service subscribe to the certmonger service? Why is the dbus service notifying the certmonger service? Why isn't the proper solution a fix to either certmonger's or dbus's systemd unit file?
3. Isn't it better to just document dbus's (broken?) behaviour and let users implement their workarounds at the profile level or rely on a separate dbus module?

Sorry about bringing up all of these issues. We haven't experienced the bug (yet?) so we're relying on you guys on this PR more than usual.

[JAORMX]

Seems we won't need this anymore.