Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restarting DBus before install certmonger #20

Closed
wants to merge 4 commits into from
+17 −1
Closed

Restarting DBus before install certmonger #20

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91e4f9c
Restarting DBus before install certmonger
arxcruz May 28, 2018
223325f
Adding manage_dbus_service option
arxcruz May 29, 2018
8a73032
Adding a notify to certmonger service
arxcruz May 29, 2018
07f30b8
Adding hasstatus and hasrestart options
arxcruz May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
# Class: certmonger
class certmonger {
class certmonger(
$manage_dbus_service = false
) {
# DBus package update from 7.4 to 7.5 breaks
# The certmonger service, so dbus must get a
# restart prior to start certmonger.
# The official solution for dbus is either
# restart the service, or reboot the machine
if $manage_dbus_service {
service { 'dbus':
ensure => running,
enable => true,
restart => '',

This comment was marked as resolved.

Sign in to view

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good to properly define the dbus service - for example, there's this module available on the puppet forge, and the service definition:
https://github.com/bodgit/puppet-dbus/blob/master/manifests/service.pp

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really usefuly to set this, according to the doc: "Specify a restart command manually. If left unspecified, the service will be stopped and then started"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What options to we have for this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, you can actually define the proper restart command if you want. But such a service, there's no use doing so I guess.

}
}

package { 'certmonger':
ensure => 'present',
Expand Down