Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

Add a CA to the example files, required for some Arvados components #10

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

javierbertoli
Copy link
Member

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Some of the library's Arvados uses, require SSL certificates signed by a valid CA or they will fail.

In testing environments (or restricted environments with no valid CA), at least certificates signed by a private CA will be required and the CA added to the browser. Some more details discussed here

Describe the changes you're proposing

This PR add an example state that creates a CA and signs the certificates with it.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Renamed some example files and directories, to better represent their purpose.

Added references to the Arvados' provision script in the documentation.
Arvados requires the certs to be signed by a CA
@javierbertoli javierbertoli requested a review from a team as a code owner December 3, 2020 22:39
@javierbertoli javierbertoli merged commit 2d2dd67 into saltstack-formulas:master Dec 3, 2020
@javierbertoli
Copy link
Member Author

🎉 This PR is included in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant