Configuration settings for generated config file #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration file, and a way to enforce a specific section ordering amongst the generated configuration sections.
Closed
noelmcloughlin
approved these changes
Sep 22, 2017
There was a problem hiding this comment.
I tested both files with latest master and works great on Ubuntu (see attached testresult.log). Lets merge. @llua could you review and merge.
|
@spoage thanks and @noelmcloughlin thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to strip out the skeleton from the generated samba configuration file, and a way to enforce a specific section ordering amongst the generated configuration sections.