Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent winbind from expanding groups #42

Merged

Conversation

noelmcloughlin
Copy link
Member

@noelmcloughlin noelmcloughlin commented Jun 11, 2018

Try to speedup AD group lookup by default. Resolve #40

The ad ID mapping back end implements a read-only API to read account and group information from Active Directory (AD)

@noelmcloughlin
Copy link
Member Author

No reviews occurred in good time - meets selfie-merge criteria .

@noelmcloughlin noelmcloughlin merged commit 84bd69b into saltstack-formulas:master Jul 22, 2018
idmap config *:range: 16777216-33554431
#idmap config *:backend = ad
idmap config *:schema_mode = rfc2307
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noelmcloughlin

I run into problem with this change (on Ubuntu 16.04 - salt 2018.3.2 (Oxygen))
For me it works if I change this into idmap config *:schema_mode: rfc2307

Error message is:

╭─silvio@nuc /srv/salt  ‹master›
╰─$ sudo salt 'nuc' state.highstate
nuc:
    Data failed to compile:
----------
    Rendering SLS 'base:samba.config' failed: Jinja syntax error: Encountered error loading yaml: could not found expected ':'
---
[...]
        encrypt passwords: yes
        # idmap config for this domain
        idmap config *:range: 16777216-33554431
        #idmap config *:backend = ad
        idmap config *:schema_mode = rfc2307
        kerberos method: secrets and keytab    <======================
        template shell: /bin/bash
        template homedir: /home/%U
        os level: 2
        winbind enum users: yes
        winbind enum groups: yes
[...]
---
/var/cache/salt/minion/files/base/samba/map.jinja(87):
---
[...]
     },
   }, grain='os')
)%}

{# start with defaults, merge osmappings, and finally pillars #}
{% import_yaml "samba/defaults.yaml" as defaults %}    <======================
{% do defaults.samba.update( samba_osmap ) %}
{% do defaults.samba.winbind.update( winbind_osmap ) %}
{% set samba = salt['pillar.get']( 'samba', default=defaults.samba, merge=True) %}

---
ERROR: Minions returned with non-zero exit code

@noelmcloughlin
Copy link
Member Author

@qno This maybe yaml rendering error as syntax appears correct.

Could you try instead 'idmap config *:schema_mode = rfc2307' to see if yaml is problem?

@noelmcloughlin
Copy link
Member Author

Moved to here: #44

@noelmcloughlin noelmcloughlin deleted the domain_member branch July 29, 2018 12:30
@noelmcloughlin noelmcloughlin restored the domain_member branch July 29, 2018 12:30
@noelmcloughlin noelmcloughlin deleted the domain_member branch July 29, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants