Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(travis): include commitlint stage #41

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

myii
Copy link
Member

@myii myii commented Feb 21, 2019


Notes follow in comments below.

@myii
Copy link
Member Author

myii commented Feb 21, 2019

With stages set, any failure in a previous stage, cancels all of the following stages.

Originally had this set up as: commitlint => test => release. However, since the main tests are crucial, those have been put first and the commitlint errors can be checked before preparing the actual release. That's the usual time that a rebase might take place with a PR, so the right time to fix the commit messages.

* https://github.com/conventional-changelog/commitlint
  - Lint commit messages.
  - Ensure that they are in accordance with `semantic-release` settings.
  - Use Travis CI to display errors and prevent release stage if so.
* https://conventional-changelog.github.io/commitlint/#/reference-rules
  - Specific rules are defined in `commitlint.config.js`.
  - Using the default rules at the time of this commit.
  - This link gives full details on the default values and how to
    provide custom settings.
@myii
Copy link
Member Author

myii commented Feb 21, 2019

IMO, this needs to be merged in before #38 -- that can be rebased afterwards.

@getSurreal
Copy link

I was reviewing the commit conventions and was wondering what qualifies as a chore?

build
ci
chore
docs
feat
fix
perf
refactor
revert
style
test

@myii
Copy link
Member Author

myii commented Feb 22, 2019

@getSurreal You and everyone else! It is a little confusing.

Anyway, have a look at the table in the CONTRIBUTING file. Basically, these are "bot" or "system" tasks that take place automatically, such as when it calculates the version number bump and updates all of the files automatically.

@myii myii merged commit f9dd953 into saltstack-formulas:master Feb 22, 2019
@myii myii deleted the PR_commitlint branch February 22, 2019 03:31
@myii
Copy link
Member Author

myii commented Feb 22, 2019

@javierbertoli @aboe76 I'm going ahead and merging this because I've got a backlog of PRs to submit. This particular PR is not introducing anything major and will be easy to revert in the event of issues.

@saltstack-formulas-travis

🎉 This PR is included in version 0.3.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants