Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use requests #59

Closed
wants to merge 2 commits into from
Closed

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Nov 2, 2015

always use requests
with requests:
we don't need to mess with urllib(1,2,3...)
we have a better ssl certificate verification

Also add option to ignore ssl certificate verification

with requests:
  we don't need to mess with urllib(1,2,3...)
  we have a better ssl certificate verification
Use requests *verify* option to ignore bad SSL certificate
@whiteinge
Copy link
Contributor

Since Pepper is intended to be used as an importable lib, it was a conscious decision to not use requests. It also doesn't buy us much since we only make simple requests/responses to a single HTTP endpoint.

...With the notable exception of SSL handling. That is a tad tricky using only the stdlib. I think we'll need to inline the ssl_match_hostname lib backport (on PyPI) into Pepper in order to properly ignore invalid certs.

Once again thank you for slinging code! 👍 But the requests lib is a heavier dep than we need for SSL certs.

@jfroche
Copy link
Contributor Author

jfroche commented Nov 2, 2015

I understand, no problem

@jfroche jfroche closed this Nov 2, 2015
@PierreR PierreR mentioned this pull request Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants