Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openvpn.sls to ver. 2.4.10 #1816

Merged
merged 2 commits into from
May 13, 2021
Merged

Conversation

TheBigBear
Copy link
Contributor

@TheBigBear TheBigBear commented Mar 31, 2021

this needs a couple more upgrades to 2.5.x but for that I first need to get on top of Jinja macros to add a new template to be used for the new msi installer they switched to from the old standard exe @dafyddj or @twangboy can you help me improve or add this msi installer section for 2.5.0 - 2.5.1 ? in PR #1818

@TheBigBear TheBigBear changed the title Update openvpn.sls to ver. 2.4.10 WIP - Update openvpn.sls to ver. 2.4.10 Mar 31, 2021
@TheBigBear
Copy link
Contributor Author

actually never mind, there is a bigger problem here, even the existing URLs are giving us 403 , so this needs more attention - will look at that over easter break. But any help on adding the msi installer template to this Jinja template would still be very much appreciated.

@TheBigBear
Copy link
Contributor Author

@dafyddj any idea why the pre-commit URL checks all fail to for openvpn? did they use to work lat year when you added 4.8.x and 4.9.x ?

@dafyddj
Copy link
Collaborator

dafyddj commented Apr 1, 2021

I'm quite happy to take a look at this @TheBigBear as it's a package I rely on.
I will need to look into what has happened to the URL checks but as you can see many changes have happened since then.

PS thanks for your recent work. It's good to see some renewed energy for this repo.

@TheBigBear
Copy link
Contributor Author

@dafyddj cool, thanks. BTW FYI, I also already have a WIP PR open for adding the msi installer in the jinja macro. Thought it best to keep the updating to latest 2.4.x 2.4.10 in this PR and deal with the jinja macro expansion and adding msi installer in a separate PR #1818

@TheBigBear TheBigBear changed the title WIP - Update openvpn.sls to ver. 2.4.10 Update openvpn.sls to ver. 2.4.10 Apr 14, 2021
@TheBigBear
Copy link
Contributor Author

All the tests are failing, BUT the installer works. This is a pre-commit URL test failure. 403 errors are redirects and work and is the way openvpn make their downloads available. I have a issue here here 1835 to fix the pre-commit URL checker to cope better with 403 URLs

this needs a couple more upgrades to 2.5.x but for that I first need to get on top of Jinja macros to add a new template to be used for the new msi installer they switched to from the old standard exe @dafyddj or @twangboy can you help me improve or add this msi installer section for 2.5.0 - 2.5.1 ?
2.4.10 still has the default fallback of win7 available for download
@twangboy twangboy merged commit 7ba7c77 into saltstack:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants