Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom grains, modules should fail on errors? #20545

Closed
sudharsh opened this issue Feb 10, 2015 · 3 comments
Closed

Custom grains, modules should fail on errors? #20545

sudharsh opened this issue Feb 10, 2015 · 3 comments
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt P2 Priority 2 Salt-SSH severity-low 4th level, cosemtic problems, work around exists stale
Milestone

Comments

@sudharsh
Copy link

Been playing around with custom salt modules and grains along with salt-ssh. I found that any errors in the modules or grains aren't bubbled up and are ignored silently. The -l debug is useful but it would be great if the salt-ssh returns an non-zero exit code atleast as a hint that something went wrong.

@rallytime rallytime added Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists Salt-SSH labels Feb 10, 2015
@rallytime rallytime added this to the Approved milestone Feb 10, 2015
@rallytime
Copy link
Contributor

@sudharsh Thanks for filing this report! Yes, we need to get a more standardized approach to exit codes and we're working on it. We've got a couple of issues open surrounding this idea, but none are specifically related to salt-ssh.

@sudharsh
Copy link
Author

Can you provide the links to those specific issues. I understand that salt
master minion defines the awesomeness of the stack but Id love to dig in
through the code.
On 10-Feb-2015 10:31 pm, "Nicole Thomas" notifications@github.com wrote:

@sudharsh https://github.com/sudharsh Thanks for filing this report!
Yes, we need to get a more standardized approach to exit codes and we're
working on it. We've got a couple of issues open surrounding this idea, but
none are specifically related to salt-ssh.


Reply to this email directly or view it on GitHub
#20545 (comment).

@jfindlay jfindlay added the Core relates to code central or existential to Salt label May 26, 2015
@msteed msteed added the P2 Priority 2 label Jun 16, 2015
@stale
Copy link

stale bot commented Nov 18, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Nov 18, 2017
@stale stale bot closed this as completed Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt P2 Priority 2 Salt-SSH severity-low 4th level, cosemtic problems, work around exists stale
Projects
None yet
Development

No branches or pull requests

4 participants