file.serialize fails to serialize due to ordered dicts

[ryan-lane]

It's possible file.serialize has been broken since everything has been switched to ordered dicts. It seems to pass data structures without transforming them and ordered dicts aren't serializable.

[rfairburn]

Here is an example of things being broken in salt 2014.7.0: https://bpaste.net/show/8b5d522ca1b3

For reference, this may be specific to the yaml formatter as the json formatter works as expected..

[rfairburn]

It looks like this had been worked around elsewhere previously here: https://github.com/saltstack/salt/blob/2014.7/salt/utils/jinja.py#L37-L43

I would assume this same solution could be used for the formatter.

[cachedout]

Hi @ryan-lane and @rfairburn. Please give #20779 a try and let me know how it goes. In my testing it resolves this issue. Thanks!

[rfairburn]

@cachedout, I was able to successfully test this this today. Here is a paste of it working:
https://bpaste.net/show/95ba3d38f4ed

[rallytime]

@rfairburn Thanks for giving that a try and confirming the fix! Once @cachedout's PR gets merged in, I think we should be able to close this one.

[favadi]

@cachedout @rallytime the bug is existed in 2014.7 branch.Is it a good idea to backport this fix to 2014.7 branch?

[jfindlay]

@favadi, yes, we should backport it, thanks.