pkgrepo.managed does not uncomment repos in sources.list

[clinta]

If an entry doesn't exist at all, it is added fine:

$ cat /etc/apt/sources.list
# demo sources.list file
$ sudo salt-call state.high "{'partner': {'pkgrepo': ['managed', {'name': 'deb http://archive.canonical.com/ubuntu/ trusty partner'}, {'enabled': True}, {'file': '/etc/apt/sources.list'}]}}"
[INFO    ] Loading fresh modules for state activity
[INFO    ] Running state [deb http://archive.canonical.com/ubuntu/ trusty partner] at time 15:03:14.008331
[INFO    ] Executing state pkgrepo.managed for deb http://archive.canonical.com/ubuntu/ trusty partner
[INFO    ] Executing command 'apt-get -q update' in directory '/home/carmstrong'
[INFO    ] {'repo': 'deb http://archive.canonical.com/ubuntu trusty partner'}
[INFO    ] Completed state [deb http://archive.canonical.com/ubuntu/ trusty partner] at time 15:03:16.996167
local:
    ----------
    pkgrepo_|-partner_|-deb http://archive.canonical.com/ubuntu/ trusty partner_|-managed:
        ----------
        __run_num__:
            0
        changes:
            ----------
            repo:
                deb http://archive.canonical.com/ubuntu trusty partner
        comment:
            Configured package repo 'deb http://archive.canonical.com/ubuntu/ trusty partner'
        duration:
            2987.836
        name:
            deb http://archive.canonical.com/ubuntu/ trusty partner
        result:
            True
        start_time:
            15:03:14.008331
$ cat /etc/apt/sources.list
# demo sources.list file
deb http://archive.canonical.com/ubuntu trusty partner

But if an entry already exists and is commented out, the state does nothing:

$ cat /etc/apt/sources.list
# demo sources.list file
# deb http://archive.canonical.com/ubuntu trusty partner
$ sudo salt-call state.high "{'partner': {'pkgrepo': ['managed', {'name': 'deb http://archive.canonical.com/ubuntu/ trusty partner'}, {'enabled': True}, {'file': '/etc/apt/sources.list'}]}}"
[INFO    ] Loading fresh modules for state activity
[INFO    ] Running state [deb http://archive.canonical.com/ubuntu/ trusty partner] at time 15:04:39.959589
[INFO    ] Executing state pkgrepo.managed for deb http://archive.canonical.com/ubuntu/ trusty partner
[INFO    ] Executing command 'apt-get -q update' in directory '/home/carmstrong'
[INFO    ] Configured package repo 'deb http://archive.canonical.com/ubuntu/ trusty partner'
[INFO    ] Completed state [deb http://archive.canonical.com/ubuntu/ trusty partner] at time 15:04:40.020455
local:
    ----------
    pkgrepo_|-partner_|-deb http://archive.canonical.com/ubuntu/ trusty partner_|-managed:
        ----------
        __run_num__:
            0
        changes:
            ----------
        comment:
            Configured package repo 'deb http://archive.canonical.com/ubuntu/ trusty partner'
        duration:
            60.866
        name:
            deb http://archive.canonical.com/ubuntu/ trusty partner
        result:
            True
        start_time:
            15:04:39.959589
$ cat /etc/apt/sources.list
# demo sources.list file
# deb http://archive.canonical.com/ubuntu trusty partner

[jfindlay]

@clinta, thanks for the report. This comment may help, although I haven't tested it in this case.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[marmarek]

consolidate: True does not solve the problem. It makes things even worse - selected sources.list get all the other entries removed (regardless of being comments or not). But the requested repository still remain commented out!

The issue is still present in salt 2018.3.2. Please reopen.

[marmarek]

PR fixing this issue: #51720