Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgrepo: fix enabling/disabling repositories on Debian #51720

Closed
wants to merge 6 commits into from

Conversation

marmarek
Copy link
Contributor

@marmarek marmarek commented Feb 19, 2019

What does this PR do?

Fix enabling/disabling repositories on Debian.
On plain Debian, enabled/disabled argument was ignored.

What issues does this PR fix or reference?

Fixes #27067

Previous Behavior

Adding/enabling Debian repository with pkgrepo.managed state did nothing if the repository was already present but commented out.

New Behavior

Repository correctly enabled.

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz
Copy link
Contributor

dwoz commented Feb 24, 2019

@marmarek Since this is a bug, can you add a regression test?

On plain Debian, enabled/disabled argument was ignored.

Fixes saltstack#27067
For now cover only cases related to saltstack#27067
@marmarek
Copy link
Contributor Author

Added.

@marmarek
Copy link
Contributor Author

When forward merging, salt.utils.is_true needs to be changed to salt.utils.data.is_true.

@Akm0d Akm0d self-requested a review March 27, 2019 19:25
@dwoz
Copy link
Contributor

dwoz commented Dec 9, 2019

@marmarek We are no longer accepting PRs against 2017.7, please re-open this against master if it's still an issue. You can reference this PR in the new one so we can retain the history.

@dwoz dwoz closed this Dec 9, 2019
@marmarek
Copy link
Contributor Author

@marmarek We are no longer accepting PRs against 2017.7, please re-open this against master if it's still an issue. You can reference this PR in the new one so we can retain the history.

Have anything changed regarding a policy for bugfix pull requests? Last time they should be made against oldest supported branch, not master.
Anyway, sure, I can rebase it on a newer branch, but I'd like to know what I need to do, to have it merged - this one was already waiting half a year with an approving review and without any comment what's wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants