Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticcache subnet group creation raises TypeError #28484

Closed
nasenbaer13 opened this issue Nov 2, 2015 · 2 comments
Closed

Elasticcache subnet group creation raises TypeError #28484

nasenbaer13 opened this issue Nov 2, 2015 · 2 comments
Labels
Bug broken, incorrect, or confusing behavior Execution-Module P3 Priority 3 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module
Milestone
Approved

Comments

@nasenbaer13
Copy link
Contributor 

conn = _get_conn(region, key, keyid, profile)

is used instead of

_get_conn(region=region, key=key, keyid=keyid, profile=profile)

resulting in

An exception occurred in this state: Traceback (most recent call last):
             File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1591, in call
               **cdata['kwargs'])
             File "/usr/lib/python2.7/dist-packages/salt/states/boto_elasticache.py", line 290, in subnet_group_present
               keyid=keyid, profile=profile)
             File "/usr/lib/python2.7/dist-packages/salt/modules/boto_elasticache.py", line 341, in subnet_group_exists
               conn = _get_conn(region, key, keyid, profile)
           TypeError: get_connection() got multiple values for keyword argument 'module'
nasenbaer13 pushed a commit to eyj/salt that referenced this issue Nov 2, 2015
Fix invalid usage of _get_conn causing saltstack#28484
7003389
nasenbaer13 pushed a commit to eyj/salt that referenced this issue Nov 2, 2015
Fix invalid usage of _get_conn causing saltstack#28484
9d80fb6
cachedout pushed a commit that referenced this issue Nov 2, 2015
Merge pull request #28485 from eyj/fix_28484
ec0cbec 
Fix invalid usage of _get_conn causing #28484
@nasenbaer13
Copy link
Contributor Author

I think the pull request #28485 has been merged.

@rallytime rallytime added Execution-Module State-Module Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P3 Priority 3 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Nov 3, 2015
@rallytime rallytime added this to the Approved milestone Nov 3, 2015
@rallytime
Copy link
Contributor

@nasenbaer13 Thanks for the report and for the fix! Love it when that happens. I'll go ahead and close this. Thanks!

@jfindlay jfindlay mentioned this issue Nov 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior Execution-Module P3 Priority 3 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@rallytime @nasenbaer13