Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting by subnet is not working #30175

Closed
grep4linux opened this issue Jan 6, 2016 · 7 comments
Closed

Targeting by subnet is not working #30175

grep4linux opened this issue Jan 6, 2016 · 7 comments
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt Duplicate Duplicate of another issue or PR - will be closed fixed-pls-verify fix is linked, bug author to confirm fix Grains P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@grep4linux
Copy link
Contributor

Targeting by subnet is not working.

My network interface is configured on the salt master as:

# ip addr show eth0
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9001 qdisc pfifo_fast state UP qlen 1000
    link/ether 02:fb:c6:6d:56:99 brd ff:ff:ff:ff:ff:ff
    inet 172.31.28.20/20 brd 172.31.31.255 scope global eth0
    inet6 fe80::fb:c6ff:fe6d:5699/64 scope link 
       valid_lft forever preferred_lft forever

# hostname -i
172.31.28.20

My minions are:

salt \* grains.get 'ip4_interfaces:eth0'
minion01:
    - 172.31.8.86
minion02:
    - 172.31.13.61
minion03:
    - 172.31.7.124
minion04:
    - 172.31.8.5
saltmaster:
    - 172.31.28.20

Targeting with the following commands:

# salt -S 172.31.13.61 status.uptime
No minions matched the target. No command was sent, no jid was assigned.
ERROR: No return received
# salt -S '172.31.13.61' status.uptime
No minions matched the target. No command was sent, no jid was assigned.
ERROR: No return received

and sometimes a response, but with incorrect targets:

# salt -S '172.31.8.86' status.uptime 
minion01:
     15:49pm  up   0:02,  0 users,  load average: 0.02, 0.02, 0.01
No minions matched the target. No command was sent, no jid was assigned.
minion02:
    Minion did not return. [No response]
minion03:
    Minion did not return. [No response]
minion04:
    Minion did not return. [No response]
saltmaster:
    Minion did not return. [No response]

and here is a full CIDR example:

salt -S '172.31.16.0/20' status.uptime
No minions matched the target. No command was sent, no jid was assigned.
ERROR: No return received
@ssgward
Copy link

ssgward commented Jan 6, 2016

@grep4linux - have you tried targeting with S@172.31.16.0/20 to see if that change in syntax works?

@ssgward ssgward added the Question The issue is more of a question rather than a bug or a feature request label Jan 6, 2016
@ssgward
Copy link

ssgward commented Jan 6, 2016

Looking at documentation here: https://docs.saltstack.com/en/latest/topics/targeting/compound.html

Not sure if this is the new way of targeting or just an additional way.

@jfindlay jfindlay added this to the Approved milestone Jan 6, 2016
@pprince
Copy link
Contributor

pprince commented Mar 8, 2016

Is this still broken on develop?

(I notice there have been a lot of dupe issues about it and work touching it lately.)

@ssgward
Copy link

ssgward commented Mar 8, 2016

I believe this is still broken.

@ssgward ssgward added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Core relates to code central or existential to Salt P2 Priority 2 Grains and removed Question The issue is more of a question rather than a bug or a feature request labels Mar 8, 2016
@rallytime
Copy link
Contributor

@grep4linux This is a duplicate of #29188 and #30962 and has been fixed by #31201.

@pprince This should be fixed on the develop branch, as the fix for this issue in #31201 was merged-forward to the 2016.3 and develop branches. Are you running into troubles still on develop? Or just wondering the status?

@rallytime rallytime added fixed-pls-verify fix is linked, bug author to confirm fix Duplicate Duplicate of another issue or PR - will be closed labels Mar 8, 2016
@pprince
Copy link
Contributor

pprince commented Mar 9, 2016

Was just wondering the status. Thanks.

Thanks,
-Paul P.

On Tue, Mar 8, 2016 at 10:54 AM, Nicole Thomas notifications@github.com
wrote:

@grep4linux https://github.com/grep4linux This is a duplicate of #29188
#29188 and #30962
#30962 and has been fixed by
#31201 #31201.

@pprince https://github.com/pprince This should be fixed on the develop
branch, as the fix for this issue in #31201
#31201 was merged-forward to the
2016.3 and develop branches. Are you running into troubles still on
develop? Or just wondering the status?


Reply to this email directly or view it on GitHub
#30175 (comment).

@cachedout
Copy link
Contributor

Given that we have a fix for this merged, I'm going to go ahead and close this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt Duplicate Duplicate of another issue or PR - will be closed fixed-pls-verify fix is linked, bug author to confirm fix Grains P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

6 participants