Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian GNU/Linux grains broken in head of 2015.8 branch #31410

Closed
terminalmage opened this issue Feb 22, 2016 · 5 comments
Closed

Debian GNU/Linux grains broken in head of 2015.8 branch #31410

terminalmage opened this issue Feb 22, 2016 · 5 comments
Assignees
@terminalmage
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt
Milestone
B 2

Comments

@terminalmage
Copy link
Contributor

885e00b broke this. I checked and this breakage did not hit 2015.8.7.

I have a fix done already, also working on a unit test.
@terminalmage terminalmage self-assigned this Feb 22, 2016
@terminalmage terminalmage added this to the B 2 milestone Feb 22, 2016
@terminalmage terminalmage added Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt TEAM Core labels Feb 22, 2016
@cachedout
Copy link
Contributor

Ah, crap. I was worried about that. My fault. Thanks for getting this.

@terminalmage
Copy link
Contributor Author

No prob. It looks like if we detect the OS as Debian instead of Debian GNU/Linux, this isn't affected.

@justinta
Copy link

@terminalmage We detect the OS as Debian

salt deb8_minion grains.item os
deb8_minion:
    ----------
    os:
        Debian

@terminalmage
Copy link
Contributor Author

Yeah, so this is why it snuck past Jenkins. I'll work on a unit test to keep this from regressing

@terminalmage terminalmage mentioned this issue Feb 22, 2016
Merged
@terminalmage
Copy link
Contributor Author

Fixed in #31418, unit test added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terminalmage terminalmage

Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt
Projects
None yet
Milestone
B 2
Development

No branches or pull requests
3 participants
@cachedout @terminalmage @justinta