Fix core grains when Debian OS detected as 'Debian GNU/Linux' #31418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in 885e00b because the updated regex now removes the slash in 'Debian GNU/Linux'. This issue did not make it into an official release, it exists only in the head of the 2015.8 branch.
|
Go Go Jenkins! |
|
The passing tests here seem to be a false positive... I don't see that my new test was actually run. I did create a new |
|
So we'll want to hold off on merging until we can figure this out. |
|
Looks like I'll need to modify runtests.py to get this working. |
|
OK, my additions to runtests.py have my unit test running and it is passing. Should be good to merge. |
cachedout
pushed a commit
that referenced
this pull request
Feb 23, 2016
Fix core grains when Debian OS detected as 'Debian GNU/Linux'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
885e00b broke this on the head of 2015.8, this pull request fixes it and adds a
unit test to ensure this doesn't regress again.
Fixes #31410.