Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2016.3 breaks existing formulas that work on 2015.8 #33532

Closed
Routhinator opened this issue May 26, 2016 · 2 comments
Closed

2016.3 breaks existing formulas that work on 2015.8 #33532

Routhinator opened this issue May 26, 2016 · 2 comments
Assignees
Labels
Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix severity-critical top severity, seen by most users, serious issues ZRELEASED - Boron
Milestone

Comments

@Routhinator
Copy link

May 26 06:57:29 db.example.com salt-minion[13276]: [CRITICAL] Rendering SLS 'base:firewalld.services' failed: while parsing a flow mapping
May 26 06:57:29 db.example.com salt-minion[13276]: in "", line 43, column 18:
May 26 06:57:29 db.example.com salt-minion[13276]: service: {'short': 'ums-listener', 'descr ...
May 26 06:57:29 db.example.com salt-minion[13276]: ^
May 26 06:57:29 db.example.com salt-minion[13276]: expected ',' or '}', but got ''
May 26 06:57:29 db.example.com salt-minion[13276]: in "", line 43, column 83:
May 26 06:57:29 db.example.com salt-minion[13276]: ... ption': 'Universal Media Server's listening port on port 5001/tc ...
May 26 06:57:29 db.example.com salt-minion[13276]: ^

@Ch3LL
Copy link
Contributor

Ch3LL commented May 26, 2016

@Routhinator just to confirm you are attempting to use this module ?

Can you share your sanitized pillar data for here

@Ch3LL Ch3LL added the info-needed waiting for more info label May 26, 2016
@Ch3LL Ch3LL added this to the Blocked milestone May 26, 2016
@Ch3LL Ch3LL added severity-critical top severity, seen by most users, serious issues ZRELEASED - Boron labels May 27, 2016
@meggiebot meggiebot added Core relates to code central or existential to Salt TEAM Core labels May 28, 2016
@meggiebot meggiebot modified the milestones: C 9, Blocked May 28, 2016
@Routhinator
Copy link
Author

Routhinator commented May 29, 2016

I am using the above module, and 'attempting' isn't the correct word. My production environment has used this module for the last few versions of salt. After further inspection it is choking on the ' in Server's in the below pillar.sls. I've tried wrapping the description in single and double quotes, but the only way to get Salt to 2016.3 to read this is to remove the '.

firewalld:
  enabled: True
  default_zone: public
  services:
    imap:
      short: imap
      description: Insecure mail IMAP port on 143/tcp.
      ports:
        tcp:
          - 143
    kerberos-adm:
      short: kerberos-adm
      description: Kerberos administration and password change port on 749/tcp+udp.
      ports:
        tcp:
          - 749
        udp:
          - 749
    microsoft-ds:
      short: microsoft-ds
      description: Microsoft Domain Services port. Successor to NetBIOS, uses 445/tcp+udp.
      ports:
        tcp:
          - 445
        udp:
          - 445
    netbios-ns:
      short: netbios-ns
      description: NetBIOS name services on ports 137-139/tcp+udp.
      ports:
        tcp:
          - 137
          - 138
          - 139
        udp:
          - 137
          - 138
          - 139
    smtps:
      short: smtps
      description: SMTP on port 587/tcp+udp for secure mail transmission.
      ports:
        udp:
          - 587
    snmp:
      short: snmp
      description: SNMP on port 161/tcp+udp for remote monitoring of the system.
      ports:
        udp:
          - 161
        tcp:
          - 161
    snmptrap:
      short: snmptrap
      description: SNMP Trap port 162/tcp+udp for remote monitoring of the system.
      ports:
        udp:
          - 162
        tcp:
          - 162
    salt-master:
      short: salt-master
      description: Ports for minions to communicate with the Salt Master on 4505-4506/tcp.
      ports:
        tcp:
          - 4505
          - 4506
    upnp-dlna:
      short: upnp-dlna
      description: UPnP/DLNA port 1900/tcp+udp for network discovery of media services. Susceptible to attack, open with caution.
      ports:
        udp:
          - 1900
        tcp:
          - 1900
    ums-listener:
      short: ums-listener
      description: Universal Media Server's listening port on port 5001/tcp.
      ports:
        tcp:
          - 5001
  zones:
    public:
      short: Public
      description: 'The default, restrictive firewalld zone.'
    trusted:
      interfaces:
        - lo

terminalmage added a commit to terminalmage/salt that referenced this issue Jun 1, 2016
The repr string formatting flag is required here.

Resolves saltstack#33532.
@terminalmage terminalmage self-assigned this Jun 1, 2016
@terminalmage terminalmage added fixed-pls-verify fix is linked, bug author to confirm fix and removed info-needed waiting for more info labels Jun 1, 2016
rallytime pushed a commit that referenced this issue Jun 2, 2016
The repr string formatting flag is required here.

Resolves #33532.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix severity-critical top severity, seen by most users, serious issues ZRELEASED - Boron
Projects
None yet
Development

No branches or pull requests

6 participants