Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arguments to Windows task creation module are not used #34135

Closed
christoe opened this issue Jun 20, 2016 · 1 comment
Closed

Arguments to Windows task creation module are not used #34135

christoe opened this issue Jun 20, 2016 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows
Milestone
Approved

Comments

@christoe
Copy link
Contributor

Description of Issue/Question

As per the documentation of the win_task module:

For additional arguments see:
py:function::edit_task

However, these (**kwargs) are not passed on to edit_task and therefore cant be set when calling create_task.

Steps to Reproduce Issue

Call create_task with any argument specified in edit_task as per the documentation of the win_task module.

Versions Report

Saltstack 2016.3.0
@christoe christoe mentioned this issue Jun 20, 2016
Closed
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 20, 2016

@christoe Looking at the code looks like you are right and these kwargs arent getting passed. We definitely need to get this fixed up. Thanks

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Platform Relates to OS, containers, platform-based utilities like FS, system based apps Windows labels Jun 20, 2016
@Ch3LL Ch3LL added this to the Approved milestone Jun 20, 2016
@christoe christoe mentioned this issue Jun 21, 2016
Merged
gitebra pushed a commit to gitebra/salt that referenced this issue Jun 27, 2016
@jojohans
Merge remote-tracking branch 'upstream/develop' into develop
efbdd9c 
* upstream/develop: (24 commits)
  salt-cloud will use list_floating_ips for Openstack (saltstack#34280)
  Update Azure ARM driver to support 2.0rc5 (saltstack#34251)
  Pylint fix
  Refactoring a bit to keep the CLI fast (saltstack#33997)
  file.find module: fix handling of broken symlinks
  Fixed typo in filtering LDAP's potential_ous
  Port boto_rds to Boto3 version 1.3.1
  Minor lint fix.
  External auth can return dynamically generated ACL from auth call.
  Fixes saltstack#34135, Fixes saltstack#34137
  some cleanup and renaming
  better way to check for openSUSE Leap
  Fix for openSUSE Tumbleweed
  fixes for fopen mock and some os_release_map for SLES11SP3
  unit tests for SUSE os grains detection
  Normalization of osfullname grain for openSUSE
  one clause to set OS grain from CPE_NAME
  Test fixed: get OS grain from /etc/os-release if possible
  fix: osarch_mock
  osarch mock for unit test
  ...

# Conflicts:
#	salt/modules/boto_rds.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior P4 Priority 4 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@christoe @Ch3LL