Refactoring a bit to keep the CLI fast #33997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1714,6 +1712,7 @@ class Caller(object): | |||
| ''' | |||
| def __init__(self, c_path=os.path.join(syspaths.CONFIG_DIR, 'minion'), | |||
| mopts=None): | |||
| import salt.minion | |||
There was a problem hiding this comment.
Maybe add a comment here for the late load as well?
|
@cachedout Woo! This will be nice. I had two tiny suggestions about adding comments in some of the places you've moved imports to later in the code. Also, it looks like the SSH tests that are failing are related to this. The other two (gem test and wheel test) are currently failing on develop. |
rallytime
added
the
pending-changes
added 9 commits
June 21, 2016 10:28
This is an ongoing attempt to avoid the loader in the CLI.
added 2 commits
June 21, 2016 14:09
|
Awesome! |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jun 27, 2016
* upstream/develop: (24 commits) salt-cloud will use list_floating_ips for Openstack (saltstack#34280) Update Azure ARM driver to support 2.0rc5 (saltstack#34251) Pylint fix Refactoring a bit to keep the CLI fast (saltstack#33997) file.find module: fix handling of broken symlinks Fixed typo in filtering LDAP's potential_ous Port boto_rds to Boto3 version 1.3.1 Minor lint fix. External auth can return dynamically generated ACL from auth call. Fixes saltstack#34135, Fixes saltstack#34137 some cleanup and renaming better way to check for openSUSE Leap Fix for openSUSE Tumbleweed fixes for fopen mock and some os_release_map for SLES11SP3 unit tests for SUSE os grains detection Normalization of osfullname grain for openSUSE one clause to set OS grain from CPE_NAME Test fixed: get OS grain from /etc/os-release if possible fix: osarch_mock osarch mock for unit test ... # Conflicts: # salt/modules/boto_rds.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My ongoing battle to keep the CLI at least somewhat lightweight.