yaml_dquote adds whitespace when string > 80 chars long

[pykler]

Description of Issue/Question

yaml_dquote filter uses the basic yaml Emitter which adds a Emitter.best_line_break when Emitter.column > Emitter.best_width (+ some additional yaml criteria). This works for yaml but doesnt work when using these strings inside sls files.

Setup

{% set v='"'*42 %}
/tmp/t.sh:
    file.managed:
        - contents: |
            # Environment variables
            export VAR={{ v | yaml_dquote }}            

Steps to Reproduce Issue

Execute the above sls, you will notice a newline is inserted before the last double quote.

Versions Report

Salt Version:
           Salt: 2016.3.1

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.7
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
         Python: 2.7.6 (default, Jun 22 2015, 17:58:13)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.3
            ZMQ: 4.1.2

System Versions:
           dist: Ubuntu 14.04 trusty
        machine: x86_64
        release: 3.13.0-48-generic
         system: Linux
        version: Ubuntu 14.04 trusty

[Ch3LL]

@pykler looks like i'm able to replicate this behavior:

➜  salt sudo salt-call --local state.sls issues.34181
[CRITICAL] Rendering SLS 'base:issues.34181' failed: could not found expected ':'; line 8

---
[...]
    file.managed:
        - contents: |
            # Environment variables
            export VAR="\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\
\"";
    <======================
---
local:
    Data failed to compile:
----------
    Rendering SLS 'base:issues.34181' failed: could not found expected ':'; line 8

---
[...]
    file.managed:
        - contents: |
            # Environment variables
            export VAR="\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\
\"";
    <======================
---

[pykler]

One solution is to initialize the Emitter with maxint as the line width

salt/salt/utils/yamlencoding.py

Line 19 in 0ef623f

yemitter = yaml.emitter.Emitter(ostream)

http://pyyaml.org/browser/pyyaml/trunk/lib/yaml/emitter.py#L38

yemitter = yaml.emitter.Emitter(ostream, width=six.MAXSIZE)

[pykler]

For anyone interested in a quick and dirty solution, in the jinja files I replaced newlines as follows. Note that this only works if your original string has no newlines, if you actually need the original newlines only your probably SOL until this is resolved. Though, I do not think there is a usecase like that where you would want some of the newlines.

{{ '"' * 42 | yaml_dquote | replace('\\\n','') }}

Notice the extra escaped backslash.