Fix s3 large file download #33599
Merged
Fix s3 large file download #33599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged) allows downloading files larger than amount of memory (non-stream reads into memory before writing to disk or uploading)
|
@rallytime, do you think this could be backported to 2015.8? |
|
Sure - See #33681. |
rallytime
added
the
ZZZ[Done]-back-ported-bf
lomeroe
added a commit
to lomeroe/salt
that referenced
this pull request
Jun 1, 2016
|
@rallytime thanks...I submitted #33682 to backport to 2016.3 as well |
rallytime
pushed a commit
that referenced
this pull request
Jun 2, 2016
lomeroe
added a commit
to lomeroe/salt
that referenced
this pull request
Jun 22, 2016
… file list from s3 to fail
rallytime
pushed a commit
that referenced
this pull request
Jun 22, 2016
…t from s3 to fail (#34207)
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jun 23, 2016
* upstream/develop: (37 commits) Use ipaddress to validate ipv4/ipv6 (saltstack#33956) Updated winrepo_test (saltstack#34227) Whitespace fix for saltstack#34235 (saltstack#34250) message_format was not set in the correct function (saltstack#34235) Typo in dockerio doc (saltstack#34244) Fixup test failure Pass through update_holds to pkg.install fix regression from saltstack#33681 which causes pulling a list of s3 objects via s3.query to fail (saltstack#34208) fix regression in s3.query from saltstack#33599 that causes pulling a file list from s3 to fail (saltstack#34207) utils/parsers.py: disable minion multiprocessing logging if only running one process Fix a pair of gitfs bugs (saltstack#34218) rsync state: Removed source existance check saltstack#25251 Linted saltstack#34200 Allow specifying memory, cpu and vcpu as kwargs for OpenNebula (saltstack#34203) Fixes saltstack#34181 no more newlines in long yaml encodes Clarify pkg.list_repo_pkgs docstring for held packages (saltstack#34188) Update saltutil.wheel docs to specify remote vs local minion behavior fix regression in s3.query from saltstack#33682 Change target for dockerng assuming default status to Nitrogen release (saltstack#34206) Correct the docstrings formatting in pkgbuild modules and state (saltstack#34194) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change s3 downloads/uploads to use pyrequests streaming. Allows for uploading/downloading files larger than the amount of memory in the system.
What issues does this PR fix or reference?
#32916
Previous Behavior
on downloads: response from server was read into memory before being written to file
on uploads: file was read into memory before uploading
New Behavior
on upload: data is streamed off disk to s3
on download: data is streamed down to disk from s3. if return_bin=True, streaming is NOT used
Tests written?
No