Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows stacktraces on msgpack on Carbon #36094

Closed
UtahDave opened this issue Sep 6, 2016 · 0 comments
Closed

Windows stacktraces on msgpack on Carbon #36094

UtahDave opened this issue Sep 6, 2016 · 0 comments
Assignees
Labels
fixed-pls-verify fix is linked, bug author to confirm fix P1 Priority 1 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-critical top severity, seen by most users, serious issues severity-high 2nd top severity, seen by most users, causes major problems Windows ZRELEASED - Carbon
Milestone

Comments

@UtahDave
Copy link
Contributor

UtahDave commented Sep 6, 2016

Description of Issue/Question

Windows stacktraces on msgpack

Setup

Install Salt from carbon branch on Windows

Steps to Reproduce Issue

<-- snip -->>
[DEBUG   ] Minion of "test.test" is handling event tag 'salt/auth/creds'
[CRITICAL] Could not deserialize msgpack message.This often happens when trying to read a file not in binary modeTo see message payload, enable debug logging and retry. Exception: Unpack failed: error = 0
[INFO    ] Returning information for job: 20160906180748572256
[[DEBUG   ] Initializing new AsyncZeroMQReqChannel for ('c:\\salt\\conf\\pki\\minion', 'davewintest', 'tcp://192.xxx.xxx.xxx:4506', 'aes')
DEBUG   ] Msgpack deserialization failure on message:
[DEBUG   ] Initializing new AsyncAuth for ('c:\\salt\\conf\\pki\\minion', 'davewintest', 'tcp://192.xxx.xxx.xxx:4506')
[ERROR   ] Exception in callback <functools.partial object at 0x00000000067A5408>
Traceback (most recent call last):
  File "C:\salt\bin\lib\site-packages\tornado\ioloop.py", line 600, in _run_callback
    ret = callback()
  File "C:\salt\bin\lib\site-packages\tornado\stack_context.py", line 275, in null_wrapper
    return fn(*args, **kwargs)
  File "C:\salt\bin\lib\site-packages\tornado\ioloop.py", line 615, in <lambda>
    self.add_future(ret, lambda f: f.result())
  File "C:\salt\bin\lib\site-packages\tornado\concurrent.py", line 232, in result
    raise_exc_info(self._exc_info)
  File "C:\salt\bin\lib\site-packages\tornado\gen.py", line 1014, in run
    yielded = self.gen.throw(*exc_info)
  File "C:\salt\bin\lib\site-packages\salt\minion.py", line 757, in handle_event
    yield [minion.handle_event(package) for minion in self.minions]
  File "C:\salt\bin\lib\site-packages\tornado\gen.py", line 1008, in run
    value = future.result()
  File "C:\salt\bin\lib\site-packages\tornado\concurrent.py", line 232, in result
    raise_exc_info(self._exc_info)
  File "C:\salt\bin\lib\site-packages\tornado\gen.py", line 789, in callback
    result_list.append(f.result())
  File "C:\salt\bin\lib\site-packages\tornado\concurrent.py", line 232, in result
    raise_exc_info(self._exc_info)
  File "C:\salt\bin\lib\site-packages\tornado\gen.py", line 282, in wrapper
    yielded = next(result)
  File "C:\salt\bin\lib\site-packages\salt\minion.py", line 1988, in handle_event
    mtag, data = salt.utils.event.MinionEvent.unpack(tag)
  File "C:\salt\bin\lib\site-packages\salt\utils\event.py", line 402, in unpack
    data = serial.loads(mdata)
  File "C:\salt\bin\lib\site-packages\salt\payload.py", line 137, in loads
    ret = msgpack.loads(msg, use_list=True, encoding=encoding)
  File "msgpack/_unpacker.pyx", line 146, in msgpack._unpacker.unpackb (msgpack/_unpacker.cpp:146)
UnpackValueError: Unpack failed: error = 0
[DEBUG   ] Initializing new AsyncZeroMQReqChannel for ('c:\\salt\\conf\\pki\\minion', 'davewintest', 'tcp://192.xxx.xxx.xxx:4506', 'clear')

Salt does seem to continue to work.

Versions Report

Carbon

@UtahDave UtahDave added Windows severity-critical top severity, seen by most users, serious issues ZRELEASED - Carbon labels Sep 6, 2016
@Ch3LL Ch3LL added severity-high 2nd top severity, seen by most users, causes major problems P1 Priority 1 Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Sep 7, 2016
@Ch3LL Ch3LL added this to the Approved milestone Sep 7, 2016
@meggiebot meggiebot modified the milestones: C 4, Approved Sep 7, 2016
@meggiebot meggiebot assigned UtahDave and cachedout and unassigned UtahDave Sep 7, 2016
cachedout pushed a commit to cachedout/salt that referenced this issue Sep 8, 2016
This was causing msgpack stacktraces everywhere because it would effectively try to unpack an empty msg.

Closes saltstack#36094
@cachedout cachedout added the fixed-pls-verify fix is linked, bug author to confirm fix label Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-pls-verify fix is linked, bug author to confirm fix P1 Priority 1 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-critical top severity, seen by most users, serious issues severity-high 2nd top severity, seen by most users, causes major problems Windows ZRELEASED - Carbon
Projects
None yet
Development

No branches or pull requests

4 participants