Remove unnecessary unpack #36152
Merged
Remove unnecessary unpack #36152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing msgpack stacktraces everywhere because it would effectively try to unpack an empty msg. Closes saltstack#36094
|
@cachedout Will do! |
|
Go Go Jenkins! |
|
Also, ping @DmitryKuzmenko on this one. I don't see any reason for this line being in there but maybe there is something I missed. |
|
Go Go Jenkins! |
rallytime
added
the
Pending-Discussion
|
I just tested this fix on Carbon on Windows and it does fix the stacktrace I was seeing. |
|
@cachedout sure! I've missed the fact it's already unpacked before. Sorry for the fault, thank you for catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing msgpack stacktraces everywhere because it would effectively try to unpack an empty msg.
Closes #36094
@rallytime This needs to go fwd to the Carbon branch, please.