Salt-Cloud failing to deploy to EC2 -- "There was a profile error: encode() argument 1 must be string, not None" #38287
Comments
danbudris
changed the title
|
@danbudris i believe this pr: #38183 will fix not being able to connect. can you try that and report back. I believe this will fix the 400 error but I think we should keep this open so we do not stack trace here if someone is receiving a 400 error. |
Ch3LL
added
Bug
|
Hi, thanks for the fast response! I've updated: With the updated config from 38183. Still experiencing the same encoding error issue as before. |
|
Hmmm I was getting the same error you were getting when i set a And I also found that adding Just to make sure i'm tracking down the right issue can you try one more thing. If you just remove your securitygroupid does it work? |
|
Yes, if I remove the I'm going to confirm that the update from the PR took and get back to you in a moment. |
|
K perfect! Let me know if it doesn't work and I can dive in and figure out which PR fixes it exactly. Like I stated above though we still shouldn't be stacktracing on that encoding error when we get a 400 error so regardless we should do a better job on the error reporting there |
|
Ok, yes, so confirmed on my test master that PR 38183 is not a fix for this issue. |
|
After continued testing it is confirmed that this issue persists (fails to deploy, stack trace, encoding error) even after applying pr 38183. |
|
Thanks for re-confirming the PR does not fix the issue. I'm diving into this more right now. will update what I find. Thanks |
|
Okay I dived a little deeper into the issue. It seems its still not working on the head of 2016.11 so my test case must have been mistaken. But what I realized is the reason I can get it working in 2016.11.0 and not 2016.11.1 is because In other words I was legitimately receiving a 400 error. Sorry for the incorrect test case. So if you could edit some code so we can see more information about your 400 error code. Can you convert: |
|
Here's the debug log. I tried it both with a SecurityGroupID and SubnetID and without a SubnetID. Same issue both times. |
|
PR here: #38316 |
|
@danbudris perfect thanks for applyig that patch. The error This is a little out of my realm at this point though and not sure as to why you are getting this conflict. ping @techhat any ideas why one would get that error above refering to the groupname and subnet parameter. I did find this on stack overflow and maybe that is related but i'm not sure. hopefully techat has some more useful insight. Also thanks @mlalpho for the fix. That fixes the encoding issue :) |
|
yep, just reread and doesn't like it's the whole issue if he's applied your patch. don't mind me :) just saw "error: encode() argument 1 must be string, not None" which was directly related to PR :) |
|
yep it seems there might be two issues going on here. Oh and i just had him switch it back to the original code so we could just quickly get the real reason behind the 400 error. I didn't mean for my patch to be the solution just a workaround.but yeah looks like your pr will fix that encode error 👍 |
|
Hi! Thanks again for being extremely responsive. When launching using
In I still recieve the following 400 response: When deploying using |
|
@danbudris thanks for trying that. do you have the patch from #38183 applied as well? |
|
Yep, 38183 is still applied |
|
K thanks for clarifying. yeah i've hit my limit on this one and hoping @techhat has more insight. |
|
Thanks for all your help @Ch3LL |
|
@Ch3LL hey, any update the issue seems to be with 2016.11.1 and 2016.11.0 and any previous version. |
|
|
@ankitforcode I've had to revert to a previous version of Salt in order to continue my deployments |
|
This happened to me because: salt.utils.aws.py line 463 I replaced it with It seems to be fixed in develop as well |
|
I'm not sure if this is helpful, but I applied the change from @fabianmurariu and that allowed me to see I had a bad value for my keypair name. Hopefully this helps narrow down where the issue is occurring. |
|
The stack trace and original issue has been resolved by #38316 I have kept this open to see if we can't resolve @danbudris 's other issue that we found once the stack trace stopped occuring. If @techhat does not get to this, i'll ping him personally on monday to see if we can't get this issue further resolved for you @danbudris |
|
@danbudris just spoke with @techhat offline. Would you be willing to open a separate issue with details just about the error |
|
I'd be happy to. I'll try to get to it as soon as I can.
…On Wed, Jan 11, 2017 at 5:30 PM, Megan Wilhite ***@***.***> wrote:
@danbudris <https://github.com/danbudris> just spoke with @techhat
<https://github.com/techhat> offline. Would you be willing to open a
separate issue with details just about the error {'Message': 'The
parameter groupName cannot be used with the parameter subnet' error with
all the information, so we can close this issue since the initial stack
trace error was resolved and this error is now a seperate error? The issue
has gotten a little messy to try to distinguish between the two so would
really help him to look through just one issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38287 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALMgaVuy9kEogepXCDF6kxV_uOJO9zajks5rRVgcgaJpZM4LOjQN>
.
|
|
I'm also getting with with 2016.11.1. I removed the security group entirely from the profile and still get My profile looks like this: My provider looks like this: My cloud map looks like this:
I too started out using provider.conf profile.conf and maps that worked on a previous salt version (2015.8.8.2) |
|
@thetoolsmith that specific error has been fixed and merged into develop (#38316) See if you still have any problems after switching your salt installation to develop branch |
|
@mlalpho Thanks. This might be a stupid question, but what's the best approach to switch to develop branch on my newly setup salt-master? |
|
@thetoolsmith If you don't want to reinstall salt or use salt-bootstrap and you're feeling brave, you could overwrite the file utils/aws.py with this run |
|
This fixed my issue. Just provisioned a vm in aws. However I got a new issue. Should I open another issue? Looks like the bootstrap failed. SaltCloudSystemExit: Command 'ssh -t -t -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oControlPath=none -oPasswordAuthentication=no -oChallengeResponseAuthentication=no -oPubkeyAuthentication=yes -oIdentitiesOnly=yes -oKbdInteractiveAuthentication=no -i /home/centos/.ssh/mykey -p 22 centos@10.0.1.81 'sudo /tmp/.saltcloud-8310720c-f6c4-4c37-aa3c-7ea46733ed7e/deploy.sh -c '"'"'/tmp/.saltcloud-8310720c-f6c4-4c37-aa3c-7ea46733ed7e'"'"' -P git v2016.11.1'' failed. Exit code: 255 |
|
running deploy.sh from the new vm console yields a bit more: [root@ip-10-0-1-81 .saltcloud-8310720c-f6c4-4c37-aa3c-7ea46733ed7e]# ./deploy.sh -P 'git v2016.11.1'
|
|
@thetoolsmith I'd recommend opening up another issue or if you patched the file try doing a clean salt reinstall of your master to develop just to be sure that it's not an issue with the patched file. |
|
I just opened saltstack/salt-bootstrap#1019. Thank you. |
|
The original issue here should be fixed in #39228 Thanks, |
|
affected by this too |
|
@arthurlogilab this original issue has been resolved with #39228 I will close this issue and wait for @danbudris to open a separate issue with the separate error he is getting. |
|
In which versions should we expect to see this fixed? |
|
The easiest way to do this is to check which tags a commit is in
In this case, the first tag that the commit in that PR is in is |
Description of Issue/Question
When attempting to launch an instance into AWS EC2 via salt-cloud, using a previously working profile, all attempts fail with error:
AWS Response Status Code: 400
Error Creating on EC2 when trying to run the Initial Deployment:
encode() argument 1 must be string, not none
Setup
salt-cloud -p base_ec2_private SERVERNAME -l debug/etc/salt/cloud.profiles.d/profiles.conf:
/etc/salt/cloud.providers.d/providers.conf:
Steps to Reproduce Issue
(Include debug logs if possible and relevant.)
Versions Report
(Provided by running
salt --versions-report. Please also mention any differences in master/minion versions.)The text was updated successfully, but these errors were encountered: