zpool.get error #38671

Open
MikeSpaceG opened this Issue Jan 10, 2017 · 1 comment

Projects

None yet

2 participants

@MikeSpaceG

Description of Issue/Question

zpool.get fails as '-o' is not a valid option with ZFS on Linux.

Setup

zfs: 0.6.5.8-1.el7_3.centos

Steps to Reproduce Issue

# salt nas zpool.get pool/users
nas:
    ----------
    error:
        invalid option 'o'
        usage:
        	get [-pH] <"all" | property[,...]> <pool> ...
        
        the following properties are supported:
        
        	PROPERTY         EDIT   VALUES
        
        	allocated          NO   <size>
        	capacity           NO   <size>
        	dedupratio         NO   <1.00x or higher if deduped>
        	expandsize         NO   <size>
        	fragmentation      NO   <percent>
        	free               NO   <size>
        	freeing            NO   <size>
        	guid               NO   <guid>
        	health             NO   <state>
        	leaked             NO   <size>
        	size               NO   <size>
        	altroot           YES   <path>
        	ashift            YES   <ashift, 9-13, or 0=default>
        	autoexpand        YES   on | off
        	autoreplace       YES   on | off
        	bootfs            YES   <filesystem>
        	cachefile         YES   <file> | none
        	comment           YES   <comment-string>
        	dedupditto        YES   <threshold (min 100)>
        	delegation        YES   on | off
        	failmode          YES   wait | continue | panic
        	listsnapshots     YES   on | off
        	readonly          YES   on | off
        	version           YES   <version>
        	feature@...       YES   disabled | enabled | active
        
        The feature@ properties must be appended with a feature name.
        See zpool-features(5).
    pool/users:
        ----------
ERROR: Minions returned with non-zero exit code

Versions Report

Master:

Salt Version:
           Salt: 2016.3.4
 
Dependency Versions:
           cffi: 1.5.2
       cherrypy: Not Installed
       dateutil: 2.4.2
          gitdb: 0.6.4
      gitpython: 1.0.1
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: 0.24.0
        libnacl: Not Installed
       M2Crypto: 0.21.1
           Mako: 1.0.3
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: 2.14
       pycrypto: 2.6.1
         pygit2: 0.24.0
         Python: 2.7.12 (default, Nov 19 2016, 06:48:10)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: 0.9.0
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4
 
System Versions:
           dist: Ubuntu 16.04 xenial
        machine: x86_64
        release: 4.4.0-57-generic
         system: Linux
        version: Ubuntu 16.04 xenial

Minion:

    Salt Version:
               Salt: 2016.11.1
     
    Dependency Versions:
               cffi: Not Installed
           cherrypy: Not Installed
           dateutil: Not Installed
              gitdb: Not Installed
          gitpython: Not Installed
              ioflo: Not Installed
             Jinja2: 2.7.2
            libgit2: Not Installed
            libnacl: Not Installed
           M2Crypto: Not Installed
               Mako: Not Installed
       msgpack-pure: Not Installed
     msgpack-python: 0.4.6
       mysql-python: Not Installed
          pycparser: Not Installed
           pycrypto: 2.6.1
             pygit2: Not Installed
             Python: 2.7.5 (default, Nov  6 2016, 00:28:07)
       python-gnupg: Not Installed
             PyYAML: 3.11
              PyZMQ: 15.3.0
               RAET: Not Installed
              smmap: Not Installed
            timelib: Not Installed
            Tornado: 4.2.1
                ZMQ: 4.1.4
     
    System Versions:
               dist: centos 7.3.1611 Core
            machine: x86_64
            release: 3.10.0-514.2.2.el7.x86_64
             system: Linux
            version: CentOS Linux 7.3.1611 Core
@Ch3LL
Contributor
Ch3LL commented Jan 11, 2017

@MikeSpaceG seems there is a difference between say freebsd and linux usage of zpool.

From freebsd man page here : zpool get [-Hp] [-o field[,...]] all | property[,...] pool ... vs the usage output: get [-pH] <"all" | property[,...]> <pool> ...

Looks like we need to edit the command if on linux.

@Ch3LL Ch3LL added this to the Approved milestone Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment