Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module.run does not work as expected in 2017.7.0 #42514

Closed
rickh563 opened this issue Jul 24, 2017 · 3 comments
Closed

module.run does not work as expected in 2017.7.0 #42514

rickh563 opened this issue Jul 24, 2017 · 3 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around ZD The issue is related to a Zendesk customer support ticket. ZRELEASED - 2017.7.2
Milestone

Comments

@rickh563
Copy link

  • Customer Reports.
  • Salt engineering validated as a bug.

Description of Issue/Question

New 2017.7.0 implementation of module.run does not work as expected.

Steps to Reproduce Issue

Attempted to use the new implementation of module.run in 2017.7.0.

To enable it I needed to set the following on the minion config (which works just fine):

use_superseded: 
  - module.run

But just like mine_functions, isn't use_superseded supposed to work when specified as a minion pillar as well??

This returns the right value:

drillops-cm@us2204-dev-c01-local-cm:~$ sudo salt-call config.get use_superseded -l quiet 
local: 
  - module.run

But the configuration does not work and the state fails with new syntax.

Example:

---state.sls 
run : 
  module.run: 
    - mine.update: 
---

Versions Report

2017.7.0

@rickh563 rickh563 added the ZD The issue is related to a Zendesk customer support ticket. label Jul 24, 2017
@rickh563
Copy link
Author

ZD-1626

@garethgreenaway garethgreenaway added this to the Approved milestone Jul 24, 2017
@garethgreenaway garethgreenaway added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P2 Priority 2 labels Jul 24, 2017
@cachedout
Copy link
Contributor

@garethgreenaway please note that i have assigned this to you for 2017.7.2

@garethgreenaway
Copy link
Contributor

@cachedout 👍 PR submitted with updated unit tests.

@Ch3LL Ch3LL closed this as completed Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around ZD The issue is related to a Zendesk customer support ticket. ZRELEASED - 2017.7.2
Projects
None yet
Development

No branches or pull requests

4 participants