Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid pillar file lead to weird exception in salt-minions #5910

Closed
Lothiraldan opened this issue Jul 3, 2013 · 1 comment · Fixed by #6305
Closed

Invalid pillar file lead to weird exception in salt-minions #5910

Lothiraldan opened this issue Jul 3, 2013 · 1 comment · Fixed by #6305
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Milestone
0.17.0

Comments

@Lothiraldan
Copy link
Contributor

I've made a typo in one of my pillar file:
pillar/newrelic.sls:

newrelic_license_key = NOT_A_CHANCE

And it lead to some weird errors on minion side: https://novapaste.novapost.net/paste/b62eaf0f6048bd3c667fee65633c5357fd3bba53#IL6Fsf1iUDVpbAaLrYACP3gD4aGr8dUFMbQv5li/Axk=

And then from the master side, when I tried to run some command, I've no output at all. Example: https://novapaste.novapost.net/paste/0cc195826f6488a63320cd7244f041aea9757b84#ut1lKYbHWlEghhwLwq6bAnVKkBwBOwVs5VTExHznbC4=

It's not blocking as I solved my pillar file typo but I've lost some time on found the problem.
@terminalmage
Copy link
Contributor

Thanks for the report.

terminalmage added a commit to terminalmage/salt that referenced this issue Jul 25, 2013
@terminalmage
Fix minion traceback when pillar SLS is malformed
a36546e 
When pillar data is rendered for use by pillar.get, SLS that does not
render to a dictionary results in a traceback on the minion. This commit
resolves that traceback.

Fixes saltstack#5910.
@terminalmage terminalmage mentioned this issue Jul 25, 2013
Merged
@s0undt3ch s0undt3ch mentioned this issue Jul 25, 2013
Merged
terminalmage added a commit that referenced this issue Jul 25, 2013
@terminalmage @basepi
Fix minion traceback when pillar SLS is malformed
1aa82a3 
When pillar data is rendered for use by pillar.get, SLS that does not
render to a dictionary results in a traceback on the minion. This commit
resolves that traceback.

Fixes #5910.

Conflicts:
	salt/pillar/__init__.py
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jul 26, 2013
@s0undt3ch
No general exception catching while rendering pillar. Refs saltstack#…
d52b109 
…6305. Refs saltstack#5910.

* All errors while processing pillar data are now logged besides being returned.
* Removed the general exception catch. All we need to is check for the expected data type. If it ain't, log the error and continue to the next iteration.
* Added a mocked test case which besides testing the issue reported on saltstack#5910, also tests for the proper includes data format and if salt fails accordingly and even if common data is merged.
s0undt3ch added a commit that referenced this issue Jul 26, 2013
@s0undt3ch @basepi
No general exception catching while rendering pillar. Refs #6305. Refs …
9e423ba 
…#5910.

* All errors while processing pillar data are now logged besides being returned.
* Removed the general exception catch. All we need to is check for the expected data type. If it ain't, log the error and continue to the next iteration.
* Added a mocked test case which besides testing the issue reported on #5910, also tests for the proper includes data format and if salt fails accordingly and even if common data is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Fix minion traceback when pillar SLS is malformed terminalmage/salt
2 participants
@Lothiraldan @terminalmage