Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Manjaro Arm os.family #60186

Open
Waaaaat opened this issue May 14, 2021 · 6 comments
Open

[BUG] Manjaro Arm os.family #60186

Waaaaat opened this issue May 14, 2021 · 6 comments
Labels
arch-linux affects this operating system Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@Waaaaat
Copy link

Waaaaat commented May 14, 2021

Hi Guys

I have manjaro(minimal) installed on my raspberrys and i want to install a package via Salt. The Problem is the pkg module doesn't recognize the packagemanager (pacman). I think its the same problem as in this bug(#41579), except for now its on arm and not on x86. Additional I tested it on my Manjaro Laptop (x86) where it works fine.

My setup:
Master:
1x Fedora (which recognizes pkg.install)
Minion:
1x Fedora(master) [Fedora 34 x86 - working fine] {master}
4x Manjaro(raspberry) [Manjaro Minimal arm - not working] {node0, node1, node2, node3}
1x Manjaro(Laptop) [Manjaro KDE x86 - working fine] {jvclt01}

I reproduced the error with the following two commands:
grafik

Here is the output of the command:
grafik

Thanks for any response and have a nice day

@Waaaaat Waaaaat added Bug broken, incorrect, or confusing behavior needs-triage labels May 14, 2021
@welcome
Copy link

welcome bot commented May 14, 2021

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@Waaaaat
Copy link
Author

Waaaaat commented May 14, 2021

Hi Guys

I have found a little work around:
1: set the salt grain manually
image
2: restart the salt-minion service (bsp: systemctl restart salt-minion)
3: now the installations work...
Its just an workaround not an fix of this problem.

Have a nice day ;-)

@OrangeDog OrangeDog added arch-linux affects this operating system severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around and removed needs-triage labels May 14, 2021
@OrangeDog OrangeDog added this to the Approved milestone May 14, 2021
@ScriptAutomate
Copy link
Contributor

A PR can be done in a similar form to #59404 or #58443:

  • In _OS_NAME_MAP, add: "manjaro-ar": "Manjaro ARM", (note that this only takes the first 10 characters form the OS name)
  • In _OS_FAMILY_MAP, add: "Manjaro ARM": "Arch",
  • In tests/unit/grains/test_core.py, add a new test function very similar to what is seen here for Pop!_OS, but do so with all the appropriate values you can find on your Manjaro ARM instance:
    @skipIf(not salt.utils.platform.is_linux(), "System is not Linux")
    def test_pop_focal_os_grains(self):
    """
    Test if OS grains are parsed correctly in Pop!_OS 20.04 "Focal Fossa"
    """
    _os_release_map = {
    "_linux_distribution": ("Pop", "20.04", "focal"),
    }
    expectation = {
    "os": "Pop",
    "os_family": "Debian",
    "oscodename": "focal",
    "osfullname": "Pop",
    "osrelease": "20.04",
    "osrelease_info": (20, 4),
    "osmajorrelease": 20,
    "osfinger": "Pop-20",
    }
    self._run_os_grains_tests("pop-20.04", _os_release_map, expectation)

I don't have Manjaro-ARM setup on something to pull those values from, but if you can grab them, you can submit a PR :)

Related feature request that may help avoid this problem from happening in supported OS derivatives, if they are properly making use of the ID_LIKE field: #59061

@Waaaaat
Copy link
Author

Waaaaat commented May 20, 2021

@ScriptAutomate and anyone else, I'm really sorry, but i have no clue how a PR works and what i need to change in the code. I will inform myself and maby i get time to try it myself, but i usually don't write code and I do not want to Include any bugs or memory leaks in my PR, so if anyone else is able to help out, and test this for him self i would be very grateful.

@bdrung
Copy link
Contributor

bdrung commented Feb 11, 2022

I worked on cleaning up the OS grain calculation on Linux in #61626. We should address this bug after the pull request got reviewed and merged.

Can you provide the content of /etc/os-release for your Manjaro installations?

@matthew-snyder
Copy link

I worked on cleaning up the OS grain calculation on Linux in #61626. We should address this bug after the pull request got reviewed and merged.

Can you provide the content of /etc/os-release for your Manjaro installations?

NAME="Manjaro ARM"
ID="manjaro-arm"
ID_LIKE="manjaro arch"
PRETTY_NAME="Manjaro ARM"
ANSI_COLOR="1;32"
HOME_URL="https://www.manjaro.org/"
SUPPORT_URL="https://forum.manjaro.org/c/arm/"
LOGO=manjarolinux

And the lsb_release info if it helps

LSB Version:    n/a
Distributor ID: Manjaro-ARM
Description:    Manjaro ARM Linux
Release:        23.02
Codename:       n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-linux affects this operating system Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

5 participants