Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AlmaLinux as os and RedHat os_family in salt/grains/core.py #59404

Merged
merged 9 commits into from Feb 8, 2021
Merged

Add AlmaLinux as os and RedHat os_family in salt/grains/core.py #59404

merged 9 commits into from Feb 8, 2021

Conversation

rgroux
Copy link
Contributor

@rgroux rgroux commented Feb 3, 2021 •
edited

What does this PR do?

Add AlmaLinux a new os and add it as new entry into RedHat os_family

What issues does this PR fix or reference?

Fixes:

New Behavior

Add new OS entry

Merge requirements satisfied?

Commits signed with GPG?

Yes

@rgroux rgroux requested a review from a team as a code owner February 3, 2021 14:29
@rgroux rgroux requested review from xeacott and removed request for a team February 3, 2021 14:29
@welcome
Copy link

welcome bot commented Feb 3, 2021

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Ch3LL
Ch3LL suggested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test coverage. You can look here for some inspiration: https://github.com/saltstack/salt/pull/58443/files

@Ch3LL Ch3LL added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Feb 4, 2021
@rgroux
Copy link
Contributor Author

rgroux commented Feb 5, 2021

Needs test coverage. You can look here for some inspiration: https://github.com/saltstack/salt/pull/58443/files

ok thanks for the tips, i add it, and it seems ok

@rgroux rgroux requested a review from Ch3LL February 5, 2021 00:36
@Ch3LL Ch3LL merged commit 2ed9e6c into saltstack:master Feb 8, 2021
@welcome
Copy link

welcome bot commented Feb 8, 2021

Congratulations on your first PR being merged! 🎉

@rgroux rgroux deleted the features/add-almalinux-distro branch February 8, 2021 19:03
@sagetherage sagetherage added the Aluminium Release Post Mg and Pre Si label Feb 18, 2021
@juliogonzalez juliogonzalez mentioned this pull request Mar 24, 2021
Merged
@ScriptAutomate ScriptAutomate mentioned this pull request May 18, 2021
Open
@myii myii mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@xeacott xeacott Awaiting requested review from xeacott

Assignees
No one assigned
Labels
Aluminium Release Post Mg and Pre Si Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgroux @Ch3LL @sagetherage