Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FreeBSD] user.present failing with Traceback #6875

Closed
cedwards opened this issue Aug 23, 2013 · 4 comments
Closed

[FreeBSD] user.present failing with Traceback #6875

cedwards opened this issue Aug 23, 2013 · 4 comments
Labels
Bug broken, incorrect, or confusing behavior help-wanted Community help is needed to resolve this Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@cedwards
Copy link
Contributor

I get the error below when trying to create a new user. Also included is my .sls:

haproxy:
  pkg:
    - installed
  service:
    - running
    - enable: True
    - config: /etc/rc.conf.local
    - reload: True
    - require:
      - pkg: haproxy
      - user: haproxy-user
    - watch:
      - file: /usr/local/etc/haproxy.conf

haproxy-user:
  user:
    - present
    - name: haproxy

/usr/local/etc/haproxy.conf:
  file.managed:
    - source: salt://haproxy/haproxy.conf
    - template: jinja
    - context:
      listen: {{ salt['network.ip_addrs']('lo1')[0] }}

----------
    State: - user
    Name:      haproxy
    Function:  present
        Result:    False
        Comment:   An exception occurred in this state: Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/salt/state.py", line 1239, in call
    ret = self.states[cdata['full']](*cdata['args'])
  File "/usr/local/lib/python2.7/site-packages/salt/states/user.py", line 367, in present
    createhome=createhome):
  File "/usr/local/lib/python2.7/site-packages/salt/modules/pw_user.py", line 79, in add
    raise TypeError('Invalid keyword argument(s): {}'.format(kwargs))
TypeError: Invalid keyword argument(s): {'createhome': True}
@basepi
Copy link
Contributor

basepi commented Aug 23, 2013

Thanks for the report. Shouldn't be too difficult to fix.

@s0undt3ch
Copy link
Collaborator

Needs a 0 there, '{0}'

Pedro Algarvio @ phone

----- Reply message -----
De: "Colton Myers" notifications@github.com
Para: "saltstack/salt" salt@noreply.github.com
Assunto: [salt] [FreeBSD] user.present failing with Traceback (#6875)
Data: sex, Ago 23, 2013 21:20
Thanks for the report. Shouldn't be too difficult to fix.


Reply to this email directly or view it on GitHub.

@s0undt3ch
Copy link
Collaborator

and seems fixed in current develop

@basepi
Copy link
Contributor

basepi commented Aug 26, 2013

Nah, it's just designed to throw an error on any unknown kwargs, and someone added the createhome kwarg recently. Looks like it has still been fixed in develop, though, and I just fixed in 0.16. Closing.

@basepi basepi closed this as completed Aug 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior help-wanted Community help is needed to resolve this Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

3 participants