Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'#' in single quoted option on cli not making it into the execution module #8585

Closed
UtahDave opened this issue Nov 16, 2013 · 1 comment · Fixed by #9039
Closed

'#' in single quoted option on cli not making it into the execution module #8585

UtahDave opened this issue Nov 16, 2013 · 1 comment · Fixed by #9039
Labels
Bug broken, incorrect, or confusing behavior Execution-Module Platform Relates to OS, containers, platform-based utilities like FS, system based apps Question The issue is more of a question rather than a bug or a feature request

Comments

@UtahDave
Copy link
Contributor

The name of this Windows network interface card has a # sign in it. Shouldn't putting the name in single quotes keep the '#' from being treated as the beginning of a comment? This behavior happens on both Windows and Linux

root@boucha:~/salt# salt \* test.echo 'Citrix PV Ethernet Adapter #1'
boucha:
    Citrix PV Ethernet Adapter

root@boucha:~/salt# salt \* test.echo 'Citrix PV Ethernet Adapter \#1'
boucha:
    Citrix PV Ethernet Adapter \#1

Just at the cli:

root@boucha:~/salt# echo #

root@boucha:~/salt# echo '#'
#
@terminalmage
Copy link
Contributor

We pass all arguments through yaml.safe_load in order to enable things like passing lists, dicts, etc. on the command line.

>>> import yaml
>>> yaml.safe_load('Citrix PV Ethernet Adapter #1')
'Citrix PV Ethernet Adapter'
>>>

I'd have to take a look at the code, but I think this can be worked around.

terminalmage added a commit to terminalmage/salt that referenced this issue Dec 4, 2013
@jfindlay jfindlay added the Platform Relates to OS, containers, platform-based utilities like FS, system based apps label May 26, 2015
basepi added a commit to basepi/salt that referenced this issue Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module Platform Relates to OS, containers, platform-based utilities like FS, system based apps Question The issue is more of a question rather than a bug or a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants