npm state module: Add parameter to specify a custom NPM server

[vortec]

The pip-state state module offers the parameters index_url and extra_index_url to pass a custom PyPI server to Salt.

The npm state module is lacking such an option, therefore I cannot use my companies NPM server to manage private NodeJS packages.

I think a parameter to specify a custom NPM server would greatly improve the npm state module.

[cachedout]

Agreed. This is a great suggestion. I'm approving it for a future release.

[vortec]

I attached some code to this issue. Not sure if and when Travis picks this up, a manual review would be appreciated too. :)

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/3375/

[s0undt3ch]

Code-wise, I see no issues with the code in this PR, if functionality is there too(ie, you tested and it does it's job), then I give my 👍

Since @cachedout was the first developer commenting this, I think we should wait for his comments and final decision.

[s0undt3ch]

Actually, the registry keyword argument in the docstring should include .. versionadded:: XYZ

XYZ is the version, if we consider this a bugfix, then 2014.1.2 or 2014.1.3 if 2014.1.2 is released soon. Otherwise, Helium.

[cachedout]

I think this is great. Let's merge it!

On Mon, Apr 14, 2014 at 3:44 PM, Pedro Algarvio notifications@github.comwrote:

Actually, the registry keyword argument in the docstring should include ..
versionadded:: XYZ

XYZ is the version, if we consider this a bugfix, then 2014.1.2 or
2014.1.3 if 2014.1.2 is released soon. Otherwise, Helium.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11926#issuecomment-40422149
.

[vortec]

@s0undt3ch Here is a test run, the package cannot be found on NPM:

(venv)[vagrant@doge] ~/salt/temp $ ls
(venv)[vagrant@doge] ~/salt/temp $ ../venv/bin/salt-call -c ../venv/etc npm.install testpack registry=http://192.168.2.154:4873 dir=`pwd`
[WARNING ] Although 'dmidecode' was found in path, the current user cannot execute it. Grains output might not be accurate.
[INFO    ] Executing command 'npm --version' in directory '/home/vagrant'
[INFO    ] output: 1.3.14
[INFO    ] Executing command 'npm install --silent --json --registry="http://192.168.2.154:4873" "testpack"' in directory '/home/vagrant/salt/temp'
[INFO    ] stdout: [
  {
    "name": "testpack",
    "version": "0.2.0",
    "from": "testpack@",
    "dependencies": {}
  }
]
local:
    ----------
    - dependencies:
        ----------
    - from:
        testpack@
    - name:
        testpack
    - version:
        0.2.0
(venv)[vagrant@doge] ~/salt/temp $ ls
node_modules
(venv)[vagrant@doge] ~/salt/temp $ ls node_modules
testpack
(venv)[vagrant@doge] ~/salt/temp $

[s0undt3ch]

Thanks You!