Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state.archive recursively set group #20707

Merged
merged 4 commits into from
Feb 16, 2015
Merged

state.archive recursively set group #20707

merged 4 commits into from
Feb 16, 2015

Conversation

russellballestrini
Copy link
Contributor

recursively set group owner, archive_user to user

modified:   salt/states/archive.py

	modified:   salt/states/archive.py
@jfindlay
Copy link
Contributor

@russellballestrini, since this involves an API change ('archive_user' -> 'user'), the change needs to be formally deprecated until some future release. See a443680 as an example. Also, there are lint errors.

@russellballestrini
Copy link
Contributor Author

@jfindlay thank you for the hints, I will bring this PR into spec for contribution by adding warnings about deprecation of archive_user in favor of the standardized user parameter, update the change log, and work out the issues with lint.

@jfindlay
Copy link
Contributor

@russellballestrini, no problem, and thank you for the fixes.

	modified:   doc/topics/releases/2014.7.2.rst
	modified:   salt/states/archive.py
	modified:   salt/states/archive.py
	modified:   salt/states/archive.py
@russellballestrini
Copy link
Contributor Author

@jfindlay please review.

@jfindlay
Copy link
Contributor

@russellballestrini, excellent, thank you.

jfindlay added a commit that referenced this pull request Feb 16, 2015
…er-group

state.archive recursively set group
@jfindlay jfindlay merged commit c47beea into saltstack:develop Feb 16, 2015
@russellballestrini russellballestrini deleted the rb-state-archive-user-group branch February 16, 2015 21:04
@russellballestrini
Copy link
Contributor Author

@jfindlay thank you! How do we target this for v2014.7.2 and/or v2015.2.0rc1

@jfindlay
Copy link
Contributor

@russellballestrini, the 2014.7 branch is almost retired as 2015.2 is now in the rc phase. If you want changes to go into release branches, the best thing to do is submit pull requests against that branch rather than develop. Since this is already merged, we can backport it, but it is cleaner and easier to submit changes against the feature branch as they will be merged into develop every few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants