-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state.archive recursively set group #20707
state.archive recursively set group #20707
Conversation
modified: salt/states/archive.py
@russellballestrini, since this involves an API change ('archive_user' -> 'user'), the change needs to be formally deprecated until some future release. See a443680 as an example. Also, there are lint errors. |
@jfindlay thank you for the hints, I will bring this PR into spec for contribution by adding warnings about deprecation of |
@russellballestrini, no problem, and thank you for the fixes. |
modified: doc/topics/releases/2014.7.2.rst modified: salt/states/archive.py
modified: salt/states/archive.py
modified: salt/states/archive.py
@jfindlay please review. |
@russellballestrini, excellent, thank you. |
…er-group state.archive recursively set group
@jfindlay thank you! How do we target this for v2014.7.2 and/or v2015.2.0rc1 |
@russellballestrini, the 2014.7 branch is almost retired as 2015.2 is now in the rc phase. If you want changes to go into release branches, the best thing to do is submit pull requests against that branch rather than develop. Since this is already merged, we can backport it, but it is cleaner and easier to submit changes against the feature branch as they will be merged into develop every few days. |
recursively set group owner, archive_user to user