fix parsing the output of parted in parted.list_()

[kevinboulain]

Hi there,

Parsing the output of parted may fail in partition.list (in the code: parted.list_).
Here is an example of such a case:

[INFO    ] Executing command 'parted -m -s /dev/sdb print' in directory '/root'
[DEBUG   ] output: Warning: Not all of the space available to /dev/sdb appears to be used, you can fix the GPT to use all of the space (an extra 44662784 blocks) or continue with the current setting? 
BYT;
/dev/sdb:31.5GB:scsi:512:512:gpt:ATA VBOX HARDDISK:;
1:1049kB:8589MB:8588MB:btrfs:SRV:;
Traceback (most recent call last):
  File ".../eggs/salt-2014.7.0-py2.7.egg/salt/cli/caller.py", line 129, in call
    ret['return'] = func(*args, **kwargs)
  File ".../eggs/salt-2014.7.0-py2.7.egg/salt/modules/parted.py", line 148, in list_
    'Problem encountered while parsing output from parted')
CommandExecutionError: Problem encountered while parsing output from parted
Error running 'partition.list': Problem encountered while parsing output from parted

At

salt/salt/modules/parted.py

Line 182 in 6560839

cols = line.replace(';', '').split(':')

, cols is: ['Warning', ' Not all of the space available to /dev/sdb appears to be used, you can fix the GPT to use all of the space (an extra 44662784 blocks) or continue with the current setting? ']

To correct this, I simply changed cmd.run to cmd.run_stdout since the message Warning: Not all of the space available to /dev/sdb appears to be used, you can fix the GPT to use all of the space (an extra 44662784 blocks) or continue with the current setting? is written on stderr.

The log with the path of this pull request on a test virtual machine:

[INFO    ] Executing command 'parted -m -s /dev/sdb print' in directory '/root'
[DEBUG   ] stdout: BYT;
/dev/sdb:31.5GB:scsi:512:512:gpt:ATA VBOX HARDDISK:;
1:1049kB:8589MB:8588MB:btrfs:SRV:;
[DEBUG   ] stderr: Warning: Not all of the space available to /dev/sdb appears to be used, you can fix the GPT to use all of the space (an extra 44662784 blocks) or continue with the current setting?
['/dev/sdb', '31.5GB', 'scsi', '512', '512', 'gpt', 'ATA VBOX HARDDISK', '']

May be related to #16188 (some other things are bugging me, but I can not directly work around this one).

[jfindlay]

@ether42, thanks for fixing this. In the future, please feel free to submit fixes directly to the oldest, supported, applicable release branches as they are regularly merged forward and this prevents us from needing to backport fixes, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

[jfindlay]

@ether42, would you mind also updating the unit tests? Thanks. Let me know if you need any help figuring them out.

[kevinboulain]

Oh yes, sorry for the units tests...
I tested the second commit with python runtests.py --name unit.modules.parted_test, it seems to pass.

I'm also sorry for making this pull request on the develop branch, I'll be more careful if I have to submit another one.

[jfindlay]

@ether42, it is not a problem, backporting is easy. Thanks for fixing this issue.