Added AWS v4 signature support #23467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slinu3d, thanks for fixing this. Will you also fix these lint errors? Thanks. |
added 2 commits
May 7, 2015 12:29
|
The lint error just does not make sense since there is a space after ',' for sure. |
|
It's probably complaining about not having a space after the |
thatch45
added a commit
that referenced
this pull request
May 8, 2015
Added AWS v4 signature support
|
@slinu3d Because of new features and changes in the 2015.5 branch, this fix is not merging forward cleanly. Could you please make these same changes in a pull request against the 2015.5 branch? Otherwise this fix will not continue into new releases of salt. |
|
Created PR (#23547) for 2015.5. |
|
Thanks @slinu3d. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds AWS v4 signature support and fixes issue #20518