Contribution: Disk module improvements #24893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Euhm, @meggiebot, why did you close this? |
|
Wow, I have no idea how that happened. Closed by accident :p Sorry! |
| @@ -3,12 +3,14 @@ | |||
| Module for managing block devices | |||
|
|
|||
| .. versionadded:: 2014.7.0 | |||
| .. deprecated: Beryllium | |||
jfindlay
added
Master Change
State-Module
Platform
|
@The-Loeki It looks like a few of the blockdev tests didn't like this very much. Would you mind taking a quick look? |
|
@cachedout: @jfindlay and I already discussed the issue in #24745; I moved all the functions to the disk mod, but presumably the blockdev unit tests need to include that. My knowledge on unit testing is too limited to fix the issue, even though it should be relatively simple to fix. So I asked jfindlay to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockdevmodule intodiskhdparmand Host Protected Area management functions