Add install confirmation to SPM #25035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfindlay
added
Core
|
Oops. I guess I accidentally added the rest of the code I was working on in that branch. |
| @@ -4,8 +4,9 @@ | |||
|
|
|||
| .. versionadded:: Beryllium | |||
| ''' | |||
| from __future__ import absolute_import, print_function | |||
There was a problem hiding this comment.
Futures are also python imports, any specific reasons to move them outside the python imports comment header?
|
Aside from my comments above, looks good. |
s0undt3ch
added a commit
that referenced
this pull request
Jun 29, 2015
Add install confirmation to SPM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.