replace bad value for master_type in example minion config #25081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, `standard` became an invalid argument for the master_type minion config bit. The bootstrap script, perhaps naively, uses this file to lay down a minion config for a newly bootstrapped system. bootstrap.sh should probably just drop an empty /etc/salt/minion rather than trying to set every available minion opt. In lieu of wading into bootstrap*, this allows Minion.eval_master() to not soil itself and continue on its merry way when not operating in one of its more advanced contexts. * mad props to the creators/maintainers of the bootstrap script. BASH makes me want to cut myself, so I appreciate complex scripts that are so very functional that I don't have to be responsible for
|
@gladiatr72 Thanks for the PR! |
|
Thanks for the mad props! I'm not alone at maintaining the script but I started and maintain (try) the madness 😄 |
cachedout
pushed a commit
that referenced
this pull request
Jul 1, 2015
…r_type-adjustment replace bad value for master_type in example minion config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point,
standardbecame an invalid argument for the master_typeminion config bit wrt Minion.eval_master(). 'str' is what is reflected in https://github.com/saltstack/salt/blob/develop/salt/config.py#L74. I haven't tracked down what changed elsewhere to make this a problem but have found that setting this in the opts.cloud.minion dict alleviates the problem of a newly minted minion soiling itself when trying to activate at the end of the bootstrap run.
Perhaps whatever code bit is laying down this squint-worthy minion config should probably just drop an empty /etc/salt/minion file letting it get updated with non-default values rather than trying to set every available minion opt.
me want to cut myself, so I appreciate complex scripts that are so
very functional that I don't have to be responsible for