Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Credentials used in glance Exec Module #26323

Merged
merged 14 commits into from
Aug 18, 2015
Merged

Fix Credentials used in glance Exec Module #26323

merged 14 commits into from
Aug 18, 2015

Conversation

0xf10e
Copy link
Contributor

@0xf10e 0xf10e commented Aug 14, 2015

Should fix #26210

@0xf10e
Copy link
Contributor Author

0xf10e commented Aug 14, 2015

Crap, I forgot to test the one function (image_create()) were I have to use v1 of the API when talking to an Icehouse-Glance...

@jfindlay jfindlay added Execution-Module State-Module Medium Change pending-changes The pull request needs additional changes before it can be merged RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Aug 14, 2015
@0xf10e
Copy link
Contributor Author

0xf10e commented Aug 14, 2015

Tested image_delete(), image_update(), image_list(), image_show() and image_create(). Everything works as intended and now returns proper {'result': <bool>, 'comment': <str>} dicts on errors.

And now Jenkins fails to fetch the right revision from my repo... :(

@rallytime
Copy link
Contributor

Thanks @0xf10e! Don't worry, Jenkins is running correctly on your latest changes. It's just a little hard to tell right now while the default job waits for build slots for the Ubuntu and CentOS tests.

They will update once the builds start for those tests.

@rallytime rallytime removed the pending-changes The pull request needs additional changes before it can be merged label Aug 17, 2015
@rallytime
Copy link
Contributor

Go Go Jenkins!

@rallytime
Copy link
Contributor

This looks great. Is this ready to be merged @0xf10e?

@0xf10e
Copy link
Contributor Author

0xf10e commented Aug 18, 2015

I think so, @rallytime

@0xf10e
Copy link
Contributor Author

0xf10e commented Aug 18, 2015

Wait a bit, I have to verify I didn't break it for Icehouse...

@0xf10e
Copy link
Contributor Author

0xf10e commented Aug 18, 2015

It's fine, I've just switched branches in the repo my _modules/glance.py symlink pointed to.
Ready to merge, @rallytime.

cachedout pushed a commit that referenced this pull request Aug 18, 2015
Merge pull request #26323 from 0xf10e/fix_glance_mod_cred
aae52d9 
Fix Credentials used in `glance` Exec Module
@cachedout cachedout merged commit aae52d9 into saltstack:2015.8 Aug 18, 2015
@cachedout cachedout mentioned this pull request Aug 18, 2015
Closed
@rallytime
Copy link
Contributor

Awesome! Thanks @0xf10e!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Execution-Module RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. State-Module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xf10e @rallytime @cachedout @jfindlay