-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for nested upstart scripts in the form of subfolder/serv… #26511
Conversation
…ice. This is implemented via an os.walk through the /etc/init folder, rather than the previous glob for *.conf method. Fixes saltstack#26478 - nested upstart services are not supported
Go Go Jenkins! |
Adds support for nested upstart scripts in the form of subfolder/serv…
Do you know when this is likely to make it into a release ? I notice, it didn't make it into v2015.5.5 or the v2015.8.0rc4. Thanks |
@rasathus, this will come out in Boron, which is the next major release after 2015.8.0 (Beryllium). |
Thanks On Mon, Sep 7, 2015 at 5:38 PM, Justin Findlay notifications@github.com
|
Hi, |
@rasathus, it should be in a couple of months. This change looks small enough that with @cachedout's permission, we could backport it to 2015.8 and it might get in before 2015.8.4 is tagged, which will happen in the next few days. |
@rasathus The current target date for a Boron release is mid-March. |
@jfindlay, It would be an incredible help if it could make it into the next tag. |
@rasathus, see #30339. Also until the change is released, you shouldn't have to package all of salt for a changed execution module. Since execution modules are a plugin layer in salt, it is relatively easy to distribute custom modules to your minions by using the If you put your changed version of |
Thank you. I hadn't realised it was possible to override standard modules
|
Adds support for nested upstart scripts in the form of subfolder/service. Please advise if there are any optimisations, or alterations you would like made prior to acceptance.