Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reworked smartos_virt to reuse most of the new smartos_vmadm #28284

Merged
merged 12 commits into from
Oct 26, 2015
Merged

reworked smartos_virt to reuse most of the new smartos_vmadm #28284

merged 12 commits into from
Oct 26, 2015

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented Oct 24, 2015

This is the last bit to close #26507

  • smartos_virt (virt) now used smartos_vmadm internally instead of calling vmadm directly
  • get_macs now also works for vms that are not running (as a side effect of the above)
  • swapped out uuid for domain to be consistent

Opened against develop as suggested in #26507, no functionally has changed so it could be a backport candidate for 2015.8 branch also.

@sjorge
smartos_virt.list_active_vms -> use smartos_vmadm internally
ef486e4
@sjorge
smartos_virt.list_inactive_vms -> use smartos_vmadm internally
d7ff0e1
@sjorge
smartos_virt.list_vms/list_domains -> use smartos_vmadm internally
27e7b02
@sjorge
smartos_virt.reboot -> use smartos_vmadm internally
c295e6c
@sjorge
smartos_virt.setmem -> use smartos_vmadm internally
4050284
@sjorge
smartos_virt.start/stop/shutdown -> use smartos_vmadm internally
d33a249
@sjorge
smartos_virt.vm_virt_type -> use smartos_vmadm internally
e0573b1
@sjorge
smartos_virt.init -> use smartos_vmadm internally
e0e2571
@sjorge
smartos_virt.stop drop through return from vmadm.delete, returned Fal…
9da1ec4 
…se on success before
@sjorge
smartos_virt.get_macs -> use smartos_vmadm internally + fix for not r…
cd79782 
…unning vms
@sjorge
smartos_virt cleanup
7ef18f4
@sjorge
smartos_virt rename uuid->domain to be consistent
e389c25
@jfindlay jfindlay added Execution-Module Master Change Platform Relates to OS, containers, platform-based utilities like FS, system based apps Release-Notes labels Oct 25, 2015
cachedout pushed a commit that referenced this pull request Oct 26, 2015
Merge pull request #28284 from sjorge/smartos_virt
b5de7e3 
reworked smartos_virt to reuse most of the new smartos_vmadm
@cachedout cachedout merged commit b5de7e3 into saltstack:develop Oct 26, 2015
@cachedout
Copy link
Contributor

Great! Thank you @sjorge !

@sjorge sjorge deleted the smartos_virt branch October 26, 2015 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Execution-Module Platform Relates to OS, containers, platform-based utilities like FS, system based apps Release-Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[input wanted] smartos_vmadm needs to be updated/cleaned up
3 participants
@sjorge @cachedout @jfindlay