Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct a bad default value in http utility #28294

Merged
merged 1 commit into from
Oct 26, 2015

Conversation

arnisoph
Copy link
Contributor

----------
          ID: haste_server_started
    Function: module.run
        Name: http.query
      Result: False
     Comment: Module function http.query threw an exception. Exception: 'NoneType' object is not iterable
     Started: 12:20:14.064283
    Duration: 2.227 ms
     Changes:

@cachedout
Copy link
Contributor

@bechtoldt We can't have mutable default arguments. This should probably be returned to None as the default function arg and then detect None for the arg in the body of the function and assign it to an empty list at that point.

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Oct 26, 2015
@arnisoph
Copy link
Contributor Author

hm, okay. I'll update my PR

@cachedout
Copy link
Contributor

@bechtoldt Much appreciated. Thanks!

@cachedout cachedout removed the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Oct 26, 2015
cachedout pushed a commit that referenced this pull request Oct 26, 2015
correct a bad default value in http utility
@cachedout cachedout merged commit 25778cf into saltstack:2015.8 Oct 26, 2015
@cachedout
Copy link
Contributor

Merged! Thanks, @bechtoldt

@arnisoph arnisoph deleted the fix_bad_param_default_val branch October 26, 2015 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants