Fix Cabal states. #28305
Merged
Fix Cabal states. #28305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cabal.update` was not inheriting the environment from the call to `cabal.installed`, which causes cabal to fail when doing things like specifying a home directory.
Fix Cabal states.
jfindlay
added
Minor Change
Platform
|
@rowillia, thanks for the fix. In the future you are welcome to submit fixes directly to the oldest supported release branch, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch. |
|
Thanks @jfindlay! Should I do that now or can you give me a hand? |
|
I went ahead and merged this and it's marked for backporting, so we'll take care of getting this into older branches. Thanks for the fix, @rowillia |
rallytime
added
ZZZ[Done]-back-ported-bf
|
Thanks @cachedout! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cabal.updatewas not inheriting the environment from the call tocabal.installed, which causes cabal to fail when doing things likespecifying a home directory.
This should fix #28279