acl: add default #28635
acl: add default #28635
Conversation
| @@ -132,9 +132,9 @@ def _parse_acl(acl, user, group): | |||
|
|
|||
| # If a user is not specified, use the owner of the file | |||
| if comps[0] == 'user' and not comps[1]: | |||
| comps[1] = user | |||
| comps[1] = 'owner' | |||
There was a problem hiding this comment.
Could you please explain the reasoning behind this?
There was a problem hiding this comment.
the setfacl command can be used two ways:
- setfacl u:root:rw /tmp/house/kitchen
- setfacl u::rw /tmp/house/kitchen
then, there will be two {"user":[{"root": {"octal":6, "permissions":{"read": true,"write": true,"execute": false,}}}]}
if changing to 'owner',it will be {"user":[{"root": {"octal":6, "permissions":{"read": true,"write": true,"execute": false,}}}]} and {"user":[{"owner": {"octal":6, "permissions":{"read": true,"write": true,"execute": false,}}}]}
|
@thegoodduke There are a lot of changes here and it's not clear to me what the intention is. Could you please better explain the issue that this PR is intended to address? I'm not comfortable merging this until we have a better explanation of what's happening here and why these changes are necessary. Thanks. |
cachedout
added
the
Pending-Discussion
jfindlay
added
Execution-Module
State-Module
Platform
|
@thegoodduke This PR is failing a few of the ACL tests and also needs some lint errors cleaned up. Could you please have another look? Thanks. |
cachedout
added
the
pending-changes
|
@thegoodduke Did you see my comment above? |
|
Go Go Jenkins! |
|
@thegoodduke We're going to have to close this if we don't get a response from the questions above. Could you please have a look? Thanks. |
|
my leader's pr has been merged(#29240), Thanks! |
add default supporting