Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of the disabled option for yumpkg #28639

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Fixed handling of the disabled option for yumpkg #28639

merged 1 commit into from
Nov 6, 2015

Conversation

RuriRyan
Copy link
Contributor

@RuriRyan RuriRyan commented Nov 6, 2015

It wasn't possible do set enabled back to 1 via state files. So if you once disabled a repository you couldn't enable it again.

This line fixes all the weird behaviour in simply converting disabled=True/False to enabled=0/1 respectively.

It wasn't possible do set enabled back to 1 via state files. So if you once disabled a repository you couldn't enable it again.

This line fixes all the weird behaviour in simply converting disabled=True/False to enabled=0/1 respectively.
@cachedout
Copy link
Contributor

@terminalmage Can you take a look here please?

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Nov 6, 2015
terminalmage pushed a commit that referenced this pull request Nov 6, 2015
Fixed handling of the disabled option for yumpkg
@terminalmage terminalmage merged commit 22bb67a into saltstack:develop Nov 6, 2015
@terminalmage
Copy link
Contributor

Looks good.

@jfindlay
Copy link
Contributor

Fixes #28225. @rallytime, can we get this backported?

@terminalmage terminalmage added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Mar 31, 2016
@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Apr 4, 2016
cachedout pushed a commit that referenced this pull request Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants