-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[salt-ssh] Add a range roster and range targeting options for the flat roster #29139
[salt-ssh] Add a range roster and range targeting options for the flat roster #29139
Conversation
7caefed
to
a278efe
Compare
a278efe
to
e010f2d
Compare
@thomaso-mirodin Nice! This will be very useful. There are a couple of minor lint errors here. Would you mind taking a look and fixing them before we get this merged? Thanks! |
5b9c532
to
18f5103
Compare
@cachedout I don't really know what to make of the last linting error, it seems to be concerned about a blank line being a 3.x incompatability XD |
salt-ssh --roster range '%%%example.range.cluster' test.ping | ||
|
||
''' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add from __future__ import absolute_import
@thomaso-mirodin Yeah, that's a bug in the way the linter displays its output in Jenkins. Sorry about that. I've commented in-line with the line that needs to be added to satisfy the linter. Thanks! |
18f5103
to
56b3302
Compare
@cachedout Looks like the the last failures are unrelated to salt-ssh, see anything else you'd like me to change? :D |
@thomaso-mirodin I think we have everything we need. I'm going to go ahead and merge this. Thanks! |
…ange-filter [salt-ssh] Add a range roster and range targeting options for the flat roster
@cachedout Hey! :D Why the switch to using format on the log messages? That causes the cost of having to format strings to be paid regardless of if that logging level is enabled or not. https://docs.python.org/2/library/logging.html#logging.Logger.debug |
This PR has two changes in it (let me know if you want them split):