file.managed: Allow local file sources to use source_hash

[terminalmage]

Fixes #26526.

[terminalmage]

While the diff may not be 100% clear on this, all this PR does is move the check if the file is a local file below where source_hash is evaluated, so that using a sha256 hash is done as a fallback if source_hash is not provided.

[lorengordon]

@terminalmage, can we add 'file' to this list of accepted source_hash protos? Will that allow us to specify a hash in the form: source_hash: file:///path/to/hashfile.hash?

[terminalmage]

Yeah, that would work. If you want to submit the PR, go ahead, otherwise I can do it.

[lorengordon]

Alright, I'm on it.

[cachedout]

Makes sense. Cool.

[lorengordon]

Maybe a slight tangent, but I think this mesage is not quite right when the source_hash scheme matches the protos list. The message seems to be saying the syntax is something like source_hash: md5=salt://path/to/hashfile.md5. But the code passes source_hash without modification directly to _urlparse(), so I think the message is wrong. The syntax would just be source_hash: <proto>://path/to/hashfile. Perhaps the message is intending to explain how extract_hash() reads the file, but I don't think that is coming across. I think that is covered in the file state docs. Also, it would maybe be nice if the message referenced the allowed protos.

[lorengordon]

Oops, already merged. Shucks.

[cachedout]

@lorengordon Can you send over a PR with those changes? I'd love to include them.

[lorengordon]

@cachedout, yep, see #29305.

[cachedout]

@lorengordon Thank you very much.

[terminalmage]

@lorengordon Thanks!