Rework of PR #31529 #31546
Merged
Rework of PR #31529 #31546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently every keyword for _pull_image is considered a bad keyword. ``` % salt node nspawn.pull_tar url bar ERROR executing 'nspawn.pull_tar': The following invalid keyword arguments were passed: verify=False. ```
terminalmage
added
the
bugfix-bckport
|
This needs a backport to 2015.8. |
|
@terminalmage Looks like a small lint error needs to be fixed here: https://jenkins.saltstack.com/job/salt-pr-lint-n/13840/violations/file/salt/modules/nspawn.py/ |
rallytime
added
the
pending-changes
terminalmage
force-pushed
the
llua-nspawn
branch
from
bb157bd
to
b2637fb
Compare
|
Lint should be fixed now. |
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original code for nspawn was written, we have gained better ways of
handling invalid kwargs. This commit builds on @llua's fix in #31529 and
updates it to use this newer code.