Add docstring examples to glance.py and nova.py [2015.8] #33487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
@jtand This looks like it is changing more thing than you're describing. Is that first commit intended here? |
rallytime
added
the
Pending-Discussion
|
@rallytime Oh oops, updated the explanation. Yes, that was intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes docstring issues that saltstack/salt-ci-images#175 exposes. Dependencies get installed that previously weren't, which loads this module.
The swift.head function does not have a body, so I've skipped it from being checked for a docstring.
This adds the new functions that #33486 did not have.
@gtmanfred Can you make sure these example look correct?
What issues does this PR fix or reference?
references saltstack/salt-ci-images#175
Tests written?
No